Menu
▾
▴
#3270 Patch: Fix composition of markup lists containing markup command list calls
Originally created by: *anonymous
Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org
Fix composition of markup lists containing markup command list calls
Composed markup lists in the parser apply normal markup commands to
markup lists, like
\with-color #red { a b c }
If those markup lists contained calls to markup list commands (like
\column-lines), the resulting behavior was undefined, at worst
producing segfaults (cf issue 2393). This patch series cleans up the
inconsistencies. It contains the following commits:
Allow unbraced forms of composed markup lists
Since composing markup lists may now work at run time, there is no
particular need for the associated syntactic restrictions.
Allow markup lists to be composed at run-time
Using a markup command on a markup list generated by a markup list
command was not previously possible. Now things like
\with-color #red \column-lines { x y z }
work as well.
Move map-markup-command-list into parser internals
Simplify interpret-markup-list
Use fold in map-markup-command-list
Text_interface::is_markup should reject markup-list-command calls
Discussion
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Owner: dak@gnu.org
Originally posted by: dak@gnu.org
Issue 2393 has been merged into this issue.
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes make, make test and a full make doc.
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
Combine successive composed markup list commands
http://codereview.appspot.com/7799048
Labels: -Patch-review Patch-new
Originally posted by: dak@gnu.org
Issue 2413 has been merged into this issue.
Originally posted by: dak@gnu.org
Patchy the autobot says: passes tests.
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes make, make test and a full make doc.
Originally posted by: dak@gnu.org
Address Ian's comment. Hopefully.
http://codereview.appspot.com/7799048
Labels: -Patch-review Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes make, make test and a full make doc.
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on Countdown - March 28 19:00 GMT
Labels: -Patch-review Patch-countdown
Originally posted by: ianhuli...@gmail.com
Latest patch-set LGTM
Cheers,
Ian
Originally posted by: dak@gnu.org
Some comments, make robust about throw not actually happening
http://codereview.appspot.com/7799048
Labels: -Patch-countdown Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes make, make test and a full make doc.
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on countdown for April 5 - 19:00 GMT
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1...@gmail.com
Patch counted down - please push
Labels: -Patch-countdown Patch-push
Originally posted by: dak@gnu.org
Pushed to staging as
commit [r6b592335270a7611578b2b801ddcc158781fd351]
Author: David Kastrup <dak@gnu.org>
Date: Fri Mar 22 11:25:15 2013 +0100
Issue 3270: Allow unbraced forms of composed markup lists
Since composing markup lists may now work at run time, there is no
particular need for the associated syntactic restrictions.
commit [rdaad014dea1243daf0c57dde1815fbabcb5d4f8c]
Author: David Kastrup <dak@gnu.org>
Date: Fri Mar 22 09:25:05 2013 +0100
Allow markup lists to be composed at run-time
Using a markup command on a markup list generated by a markup list
command was not previously possible. Now things like
\with-color #red { \column-lines { x y z } }
work as well.
commit [re7d8a172d79b5172dfc66df8c17cb292d6baccbb]
Author: David Kastrup <dak@gnu.org>
Date: Thu Mar 21 20:32:33 2013 +0100
Move map-markup-command-list into parser internals
commit [rc43b641be5e61e66784f5c8eb2ee07ae76abd7e1]
Author: David Kastrup <dak@gnu.org>
Date: Wed Mar 20 13:42:59 2013 +0100
Simplify interpret-markup-list
commit [rc7d8081aeedd9d35cc2131c2e2a4ad34e9265245]
Author: David Kastrup <dak@gnu.org>
Date: Wed Mar 20 13:10:47 2013 +0100
Use fold in map-markup-command-list
commit [rc5c999bde07947c1e5a168436e3159e11c1cb610]
Author: David Kastrup <dak@gnu.org>
Date: Wed Mar 20 10:57:27 2013 +0100
Text_interface::is_markup should reject markup-list-command calls
Labels: -Patch-push Fixed_2_17_16
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified