Menu

#3200 Patch: Make ly:make-unpure-pure-container accept a single callback

Verified
nobody
Enhancement
2013-03-17
2013-02-21
Anonymous
No

Originally created by: *anonymous

Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org

Make ly:make-unpure-pure-container accept a single callback

Like with fixed values, this gets duplicated for the pure value as
well, but converted into a three-argument callback.

http://codereview.appspot.com/7382046

Related

Issues: #3199

Discussion

  • Google Importer

    Google Importer - 2013-02-21

    Originally posted by: dak@gnu.org

    (No comment was entered for this change.)

    Owner: dak@gnu.org

     
  • Google Importer

    Google Importer - 2013-02-21

    Originally posted by: dak@gnu.org

    Patchy the autobot says: passes tests.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2013-02-21

    Originally posted by: dak@gnu.org

    Allow arbitrary argument number

    http://codereview.appspot.com/7382046

    Labels: -Patch-review Patch-new

     
  • Google Importer

    Google Importer - 2013-02-21

    Originally posted by: dak@gnu.org

    Patchy the autobot says: passes tests.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2013-02-21

    Originally posted by: dak@gnu.org

    Change function signature to make for better error behavior

    http://codereview.appspot.com/7382046

    Labels: -Patch-review Patch-new

     
  • Google Importer

    Google Importer - 2013-02-21

    Originally posted by: dak@gnu.org

    Patchy the autobot says: passes tests.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2013-02-21

    Originally posted by: pkx1...@gmail.com

    Patchy the autobot says: passes make, make test and a full make doc.

     
  • Google Importer

    Google Importer - 2013-02-22

    Originally posted by: dak@gnu.org

    I'd suggest this is ready for countdown: it is a very well-confined change, the code is not exercised in current master but would help with writing the kind of some of Mike's work in a more straightforward manner.  Testing it in the Scheme sandbox verifies that it works as intended.

     
  • Google Importer

    Google Importer - 2013-02-22

    Originally posted by: mts...@gmail.com

    Agreed.

     
  • Google Importer

    Google Importer - 2013-02-22

    Originally posted by: pkx1...@gmail.com

    Patch on countdown for 20130225 - 19:00 GMT

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2013-02-25

    Originally posted by: pkx1...@gmail.com

    Patched counted down. Please Push

    Labels: -Patch-countdown Patch-push

     
  • Google Importer

    Google Importer - 2013-02-25

    Originally posted by: dak@gnu.org

    Pushed to staging as
    commit [r4961143c8c79984852c575e2b2b3922e5f7540ce]
    Author: David Kastrup <dak@gnu.org>
    Date:   Thu Feb 21 20:02:48 2013 +0100

        Issue 3200: Make ly:make-unpure-pure-container accept a single callback
       
        Like with fixed values, this gets duplicated for the pure value as
        well, but converted into a callback taking two more arguments (which
        are ignored).

    Labels: -Patch-push Fixed_2_17_14
    Status: Fixed

     
  • Google Importer

    Google Importer - 2013-03-17

    Originally posted by: Elu...@gmail.com

    (No comment was entered for this change.)

    Status: Verified