#3174 Add native support of pitched ornamentations

[Anonymous]

Originally created by: *anonymous

Originally created by: colingh...@gmail.com
Originally owned by: dak@gnu.org

Xavier Scheuer made a feature request here:

http://lists.gnu.org/archive/html/bug-lilypond/2013-02/msg00054.html

Text of bug report follows:

--------------

Hi,

In some part of the thread "A must-see for anybody on this list" on
lilypond-user, Joseph Rushton Wakeling and David Kastrup agreed that
LilyPond is missing a proper command for pitched ornamentations.

Instead of the current code
  a4\mordent^\markup{ \flat }
we should have a dedicated command
  a4\pitchedMordent { bes }
that would properly change the accidental when transposed, like
\pitchedTrill actually works (IIUC).

This enhancement could be applied to all the ornament scripts, but
differently for each of them (turn for example could have the upper
note or the lower note (or both) with accidentals, so printed above
and/or below the turn).

Original discussion:
http://lists.gnu.org/archive/html/lilypond-user/2013-02/msg00286.html
http://lists.gnu.org/archive/html/lilypond-user/2013-02/msg00287.html
http://lists.gnu.org/archive/html/lilypond-user/2013-02/msg00295.html

Cheers,
Xavier

--
Xavier Scheuer <address@hidden>

[Google Importer]

Originally posted by: dak@gnu.org

Issue 3174: Implement \accidental markup and \pitched command for transposable accidental markups

This is a building block for creating pitched ornaments behaving
sensibly under transposition.

It would be arguable to define \pitched differently so that it works
only on ornaments and does the stacking itself, like
c^\pitched\trill des

and instead give the current version of \pitched a name like \pitchify.

As it stands, here are the implemented meanings:

\accidental markup:
Draw an accidental based on the @var{pitch} property of the causing
event.  This is typically set in music using the (transposable)
@code{\pitched} command, like

@lilypond[verbatim,quote]
melody = \relative c'
  { \key c\major c2^\trill^\pitched des -\markup \accidental d! }
\new Staff { \melody }
\new Staff { \transpose c' e' \melody }
@end lilypond

\pitched music function: arguments pitch and music:
"Give @var{music} a pitch of @var{pitch}.

http://codereview.appspot.com/7323060

Labels: Patch-new
Owner: dak@gnu.org
Status: Started

[Google Importer]

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc.

Labels: -Patch-new Patch-review

[Google Importer]

Originally posted by: dak@gnu.org

Issue 3122 has been merged into this issue.

[Google Importer]

Originally posted by: pkx1...@gmail.com

Seems this still needs some decisions to be made on the current patch

Labels: -Patch-review Patch-needs_work

[Trevor Daniels]

Reverting the Status to Accepted, as it is well over 2 years since the latest activity. Looking at the comments on the Rietveld patch it seems that the approach needs further thought and design.