LilyIssues / Issues / #3161 Patch: Standardizes use of empty extents in pure heights and skylines.

Google Importer - 2013-02-09

Originally posted by: mts...@gmail.com

(No comment was entered for this change.)

Owner: mts...@gmail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-09

Originally posted by: pkx1...@gmail.com

Fails make.

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-09

Originally posted by: mts...@gmail.com

Rebased off current master.

http://codereview.appspot.com/7310075

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-09

Originally posted by: mts...@gmail.com

Way odd...compiles clean on my machine. I don't think the rebase made much of a difference, but I'd appreciate it if you tested it out anyway. If this doesn't compile, perhaps try to compile master by itself and/or do a make clean.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-09

Originally posted by: mts...@gmail.com

Forgot to add that, if it fails to compile again, please copy and paste the last 10-20 lines of make so I can see where it's failing.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-09

Originally posted by: mts...@gmail.com

Adds regtest.

http://codereview.appspot.com/7310075

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-09

Originally posted by: pkx1...@gmail.com

Still fails make

--snip--
/tmp/lilypond-autobuild/lily/skyline.cc:87:31: warning: valgrind/valgrind.h: No su
ch file or directory
rm -f ./out/slash-repeat-engraver.dep; DEPENDENCIES_OUTPUT="./out/slash-repeat-eng
raver.dep ./out/slash-repeat-engraver.o" g++ -c -Woverloaded-virtual -I/usr/inclu
de/python2.6 -I/usr/include/python2.6 -fno-strict-aliasing -g -fwrapv -DHAVE_CONF
IG_H -I/tmp/lilypond-autobuild/lily/include -I./out -I/tmp/lilypond-autobuild/flo
wer/include -I../flower/./out -I../flower/include -I/tmp/lilypond-autobuild/lily/o
ut -g -pipe -pthread -I/usr/include/freetype2   -pthread -I/usr/include/pango-1.0
-I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -W
no-pmf-conversions -W -Wall -Wconversion -o out/slash-repeat-engraver.o /tmp/lily
pond-autobuild/lily/slash-repeat-engraver.cc
rm -f ./out/slur-configuration.dep; DEPENDENCIES_OUTPUT="./out/slur-configuration.
dep ./out/slur-configuration.o" g++ -c -Woverloaded-virtual -I/usr/include/python
2.6 -I/usr/include/python2.6 -fno-strict-aliasing -g -fwrapv -DHAVE_CONFIG_H -I/
tmp/lilypond-autobuild/lily/include -I./out -I/tmp/lilypond-autobuild/flower/inclu
de -I../flower/./out -I../flower/include -I/tmp/lilypond-autobuild/lily/out -g -p
ipe -pthread -I/usr/include/freetype2   -pthread -I/usr/include/pango-1.0 -I/usr/i
nclude/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -Wno-pmf-co
nversions -W -Wall -Wconversion -o out/slur-configuration.o /tmp/lilypond-autobui
ld/lily/slur-configuration.cc
/tmp/lilypond-autobuild/lily/skyline.cc: In function 'Interval fatten_skinny_build
ings(Real, Real)':
/tmp/lilypond-autobuild/lily/skyline.cc:93: error: 'VALGRIND_PRINTF_BACKTRACE' was
not declared in this scope
make[1]: *** [out/skyline.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/tmp/build-lilypond-autobuild/lily'
make: *** [all] Error 2

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-09

Originally posted by: mts...@gmail.com

Damn you valgrind...

http://codereview.appspot.com/7310075

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-09

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc. Diffs here - https://www.yousendit.com/download/UW13N3RSZEtWRC81SE1UQw

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-09

Originally posted by: mts...@gmail.com

Responses to Keith's comments

http://codereview.appspot.com/7310075

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-10

Originally posted by: mts...@gmail.com

Changes standard-stencil-height to pure-safe-stencil-height

http://codereview.appspot.com/7310075

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-10

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc. Diffs here -
https://www.yousendit.com/download/UW13N3RUQ0NHa1BsZThUQw

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-13

Originally posted by: pkx1...@gmail.com

Countdown to 20130215 - although keith made comments it looked like he was concurring than questioning or making suggestions.

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-16

Originally posted by: pkx1...@gmail.com

David made comments - setting back to Patch-Needs_Work

Labels: -Patch-countdown Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-20

Originally posted by: mts...@gmail.com

Implements Keith's suggestion of eliminating EPS

http://codereview.appspot.com/7310075

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-21

Originally posted by: pkx1...@gmail.com

Mike, this seems to fail to apply to current master

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-21

Originally posted by: mts...@gmail.com

Rebases against current mster

http://codereview.appspot.com/7310075

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-21

Originally posted by: pkx1...@gmail.com

Fails Make

--snip--
Processing `/tmp/lilypond-autobuild/ly/generate-documentation.ly'
Parsing...
[/tmp/lilypond-autobuild/ly/init.ly
[<string>
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/declarations-init.ly
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/music-functions-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/toc-init.ly]
Using `nederlands' note names...
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/drumpitch-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/chord-modifiers-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/script-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/chord-repetition-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/scale-definitions-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/dynamic-scripts-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/spanners-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/predefined-fretboards-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/string-tunings-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/property-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/grace-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/midi-init.ly
   [/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/performer-init.ly]]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/paper-defaults-init.ly
   [/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/titling-init.ly]
   [/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/text-replacements.ly]]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/context-mods-init.ly]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/ly/engraver-init.ly/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/lily.scmBacktrace:
In unknown file:
   ?: 0* [lilypond-main ("/tmp/lilypond-autobuild/ly/generate-documentation")]
In /tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/lily.scm:
877: 1* (let* ((failed #)) (if (ly:get-option #) (begin #)) ...)
877: 2* [lilypond-all ("/tmp/lilypond-autobuild/ly/generate-documentation")]
890: 3 (let* ((failed #) (separate-logs #) (ping-log #) ...) (gc) ...)
902: 4* [for-each #<procedure #f #> #]
In unknown file:
   ?: 5* [#<procedure #f (x)> "/tmp/lilypond-autobuild/ly/generate-documentation"]
In /tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/lily.scm:
904: 6* (let* (# # #) (if separate-logs #) (if ping-log #) ...)
915: 7* [lilypond-file #<procedure #f #> ...]
950: 8 [catch ly-file-failed #<procedure #f ()> #<procedure #f (x . args)>]
In unknown file:
   ?: 9* [#<procedure #f ()>]
In /tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/lily.scm:
951: 10* [ly:parse-file "/tmp/lilypond-autobuild/ly/generate-documentation"]
In /tmp/lilypond-autobuild/ly/init.ly:
   9: 11* [session-initialize #<procedure #f ()>]
In /tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/lily.scm:
97: 12 (if (ly:undead? lilypond-declarations) (begin (for-each # #)) ...)
107: 13 (begin (thunk) (let (#) (module-for-each # #) ...))
108: 14* [#<procedure #f ()>]
In /tmp/lilypond-autobuild/ly/init.ly:
17: 15 [ly:parser-parse-string # "\\include \"declarations-init.ly\""]

/tmp/lilypond-autobuild/ly/init.ly:17:4: In procedure ly:parser-parse-string in expression (ly:parser-parse-string (ly:parser-clone parser) "\\include \"declarations-init.ly\""):
/tmp/lilypond-autobuild/ly/init.ly:17:4: Unbound variable: pure-safe-stencil-height

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-21

Originally posted by: mts...@gmail.com

Correct function name change

http://codereview.appspot.com/7310075

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-21

Originally posted by: pkx1...@gmail.com

Passes Make, make test and make doc.

Reg test diffs

https://www.yousendit.com/download/UW14ZGlvWlRJMHY0WjlVag

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-22

Originally posted by: pkx1...@gmail.com

Patch on Countdown for 2013220225 - 19:00 GMT (although there is a comment from David, I am not sure it is going to stop the patch).

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-24

Originally posted by: mts...@gmail.com

Better handling of point stencils for repeat ties.

http://codereview.appspot.com/7310075

Labels: -Patch-countdown Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-24

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc. Reg test diffs here - https://www.yousendit.com/download/UW15WUhsT00wVWs5WThUQw

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-25

Originally posted by: pkx1...@gmail.com

Patch on countdown for 27th Feb 2013 - 19:00 GMT

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-27

Originally posted by: mts...@gmail.com

Uses stencil to get RepeatTie height

http://codereview.appspot.com/7310075

Labels: -Patch-countdown Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Patch: Standardizes use of empty extents in pure heights and skylines.

Issue Tracker for LilyPond

Searches

Help

#3161 Patch: Standardizes use of empty extents in pure heights and skylines.

Related

Discussion