#3156 Patch: Prevents vertical axis groups with empty skylines

[Anonymous]

Originally created by: *anonymous

Originally created by: mts...@gmail.com
Originally owned by: mts...@gmail.com

Prevents vertical axis groups with empty skylines

http://codereview.appspot.com/7311048

[Google Importer]

Originally posted by: mts...@gmail.com

(No comment was entered for this change.)

Owner: mts...@gmail.com

[Google Importer]

Originally posted by: pkx1...@gmail.com

passes make and make test and a full make doc. I have attached a reg test that is trivial but I notice much better spacing, however the numerals in the parenethesis are as they were, but not as nicely spaced IMO as the two figured bass numbers that have changed.

Just an observation

Labels: -Patch-new Patch-review

[Google Importer]

Originally posted by: mts...@gmail.com

Prevents vertical axis groups with empty skylines

http://codereview.appspot.com/7311048

Labels: -Patch-review Patch-new

[Google Importer]

Originally posted by: pkx1...@gmail.com

Passes Make, Make check and full make doc.

Probably not noticed before (and because I don't really know if they are significant or not) but the cell count on a couple of reg tests is quite different (much higher).

--snip--
2.382280    

time    : 0
cells   : 795970

time    :        0 (0.000)
cells   :  1081725 (-0.152)

input/regression/song-tempo.profile

0.350211    

time    : 0
cells   : 1998134

time    :        0 (0.000)
cells   :  2156788 (-0.038)

input/regression/markup-line-styles.profile

0.324477    

time    : 0
cells   : 936208

time    :        0 (0.000)
cells   :  1005614 (-0.036)

input/regression/markup-lines-identifier.profile

--snip--

Labels: -Patch-new Patch-review

[Google Importer]

Originally posted by: k-ohara5...@oco.net

This happens to hide the bug in issue 3160, so let's at least find out what went wrong there before doing this. 

Somehow, this input was spaced properly in version 2.16,
whereas we know that lines with empty extents were not removed (i.e., no VerticalAxisGroup::suicide() ) because Trevor B's use of zero-extents was working then
<https://lists.gnu.org/archive/html/lilypond-devel/2013-02/msg00032.html>

Blockedon: lilypond:3160

[Google Importer]

Originally posted by: pkx1...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-review Patch-waiting

[Trevor Daniels]

This was set to Patch:waiting due to being blocked by Issue 3160, but that was fixed over 2 years ago. So the patch associated with this issue seems ready to be progressed. As the original author is not currently active, I'm setting the Status to Accepted in the hope someone else might pick this up.