Menu

#3128 add the "Haydn turn" (reversed turn with vertical slash) to LilyPond

Fixed
Enhancement
2018-04-15
2013-01-21
Anonymous
No

Originally created by: *anonymous

Originally created by: Elu...@gmail.com

Michael Rivers asks for addition of the above mentioned turn

a few aspects have already been discussed here http://lilypond.1069038.n5.nabble.com/Requesting-an-addition-td139819.html

Discussion

  • Malte Meyn

    Malte Meyn - 2018-04-08

    Issue 3128: add Haydn-style turns to Feta

    This adds two variants of a turn with a vertical slash:
    scripts.slashturn (SMuFL U+E569) and scripts.haydnturn (SMuFL U+E56F)

    Also, scripts \slashturn and \haydnturn are added.

    I’ll attach a PDF showing them being used to the sourceforge issue.

    http://codereview.appspot.com/340660043

     
  • Malte Meyn

    Malte Meyn - 2018-04-08

    See them in action.

     
  • Malte Meyn

    Malte Meyn - 2018-04-08
     
  • Malte Meyn

    Malte Meyn - 2018-04-08
    • Description has changed:

    Diff:

    
    
    • assigned_to: Malte Meyn
    • Needs: -->
    • Type: -->
     
  • Malte Meyn

    Malte Meyn - 2018-04-08

    Fails make doc but I’ve already found the reason and will provide a new patch set soon (after running make doc and make check again).

     
  • Malte Meyn

    Malte Meyn - 2018-04-08

    add the turns to script-chart.ly (only used by the German NR), add the turns to NR and Changes

    http://codereview.appspot.com/340660043

     
  • Anonymous

    Anonymous - 2018-04-08
    • Needs: -->
    • Type: -->
     
  • Anonymous

    Anonymous - 2018-04-08

    Fails make doc - you need to add it also in ../Documentation/included/script-chart.ly

     
  • Anonymous

    Anonymous - 2018-04-08
    • Patch: new --> needs_work
    • Type: --> Enhancement
     
    • Anonymous

      Anonymous - 2018-04-08

      Sorry, ignore last comment, I was still testing the previous patch

       
  • Anonymous

    Anonymous - 2018-04-08
    • Patch: needs_work --> review
     
  • Anonymous

    Anonymous - 2018-04-08

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-04-11
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2018-04-11

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-04-12
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-04-12

    Patch on countdown for April 15th

     
  • Anonymous

    Anonymous - 2018-04-15
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-04-15

    Patch counted down - please push

     
  • Malte Meyn

    Malte Meyn - 2018-04-15
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Malte Meyn

    Malte Meyn - 2018-04-15

    commit 5b1c145c5d9dd5e897f2bc7929e1070b32510ad1
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Sun Apr 8 18:28:22 2018 +0200

    Issue 3128/3: add slashturn/haydnturn to Docs
    
    Add the changes to Notation Reference, Changes and script-chart.ly.
    The file script-chart.ly is used only by the German translation of the
    docs.
    

    commit 2cebadae84f0e1278aeec051b9de7e166c3408df
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Sun Apr 8 15:58:19 2018 +0200

    Issue 3128/2: add scripts \slashturn & \haydnturn
    

    commit 12fe78825798191ecb7e5a4ee3064679773ae1ab
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Sun Apr 8 15:52:44 2018 +0200

    Issue 3128/1: add Haydn-style turns to Feta
    
    This adds two variants of a turn with a vertical slash:
    scripts.slashturn (SMuFL U+E569) and scripts.haydnturn (SMuFL U+E56F)