Menu
▾
▴
1 Attachments
#3109 Unusual fingerings sometimes collide, or come out of order
Originally created by: *anonymous
Originally created by: k-ohara5...@oco.net
Originally owned by: mts...@gmail.com
After the patch for issue 2527, there are a few corner cases that collide.
The comments on the patch for 2674 should show a way to simplify the code and remove these corners.
{\set fingeringOrientations = #'(left)
<g-1 a-2 b-3 >4
<g-1 a-\tweak #'text "—" -2 b-3 >
<b-1 a-\tweak #'text "----" -2 b-3 >
<g-1 a-2 b-3 c'-4 d'-5 e'-6 f'-7> }
Originally posted by: m...@mikesolomon.org
You can apply https://codereview.appspot.com/6854121 if that does the trick.
Originally posted by: mts...@gmail.com
Removes box quarantine
http://codereview.appspot.com/7171043
Labels: Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the Autobot says passes Make, Make check and Full make doc.
reg test diffs attached
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
The regtest differences from the review are basically of the ugly->ugly kind. It would be nice if there was some proof of positive change associated with the issue. It is also unclear why there are two different patch proposals on Rietveld. Only the second one appears to have seen testing. There does not appear to be any regtest showing positive change (and thus presumably addressing the actual issue this is supposed to be about).
Put on countdown for 2013/01/25 17:00 UTC, but I'd be glad to see anything supporting the idea that this solves any issue, preferably the tracked one.
Labels: -Patch-review Patch-countdown
Owner: mts...@gmail.com
Originally posted by: k-ohara5...@oco.net
The patch does repair the problems shown in the bug report, as attached.
The bug report contains unusual input, but I could think of no simple case that would expose the holes in the patch for issue 2527. The code in that patch was baroque, so I am happy to see clean code replacing it.
Related
Issues:
#2527Originally posted by: dak@gnu.org
Countdown complete. You might want to recheck comment #4 and comment #5 before pushing.
Labels: -Patch-countdown Patch-push
Status: Started
Originally posted by: mts...@gmail.com
Pushed to staging as [r251a3b012c71a7d5d4ae64a2c89dfb5d6869ab07].
Labels: Fixed2_11_17
Status: Fixed
Originally posted by: PhilEHol...@googlemail.com
Correct version
Labels: -Fixed2_11_17 Fixed_2_17_11
Originally posted by: PhilEHol...@googlemail.com
(No comment was entered for this change.)
Status: Verified
.