Menu
▾
▴
#3108 Patch: Better staggering of accidental placements.
Originally created by: *anonymous
Originally created by: mts...@gmail.com
Originally owned by: mts...@gmail.com
Better staggering of accidental placements.
Makes sure that, on average, accidentals are closer to the notes
while preserving octaves lining up.
Originally posted by: PhilEHol...@googlemail.com
Confirming this fixes Werner's problem and makes a minor change to the ordering of one of the accidental set in the accidental placement regtest. See details in PNGs.
Originally posted by: pkx1...@gmail.com
Passes Make, Make check and full make doc.
Reg test diffs attached
Labels: -Patch-new Patch-review
Originally posted by: lemzw...@googlemail.com
Here is `Werner's problem': http://lists.gnu.org/archive/html/lilypond-user/2013-01/msg00567.html
Originally posted by: lemzw...@googlemail.com
A related problem is issue #3106.
Related
Issues: #3106
Originally posted by: mts...@gmail.com
Better staggering of accidental placements.
Makes sure that, on average, accidentals are closer to the notes
while preserving octaves lining up.
http://codereview.appspot.com/7101045
Labels: -Patch-review Patch-new
Originally posted by: pkx1...@gmail.com
Passes Make, Make check and full make doc.
Reg test diffs attached
Labels: -Patch-new Patch-review
Originally posted by: lemzw...@googlemail.com
Looking at the screenshot from #6, it doesn't feel like an improvement...
Originally posted by: mts...@gmail.com
Better staggering of accidental placements.
Makes sure that, on average, accidentals are closer to the notes
while preserving octaves lining up.
http://codereview.appspot.com/7101045
Labels: -Patch-review Patch-new
Originally posted by: mts...@gmail.com
Better staggering of accidental placements.
Makes sure that, on average, accidentals are closer to the notes
while preserving octaves lining up.
http://codereview.appspot.com/7101045
Originally posted by: pkx1...@gmail.com
Passes Make, Make check and full make doc.
Reg test diffs attached
Labels: -Patch-new Patch-review
Originally posted by: lemzw...@googlemail.com
Now the reg test looks much better, thanks!
BTW, how does this chord get formatted?
\relative c' {
<gis bis' dis gis bis>2
}
Originally posted by: m...@mikesolomon.org
with (good.png) and without (bad.png) patch applied
Originally posted by: lemzw...@googlemail.com
Thanks, I've feared this :-) I still think there shouldn't be a gap between the lowest accidental and the note head. Hopefully, I can find something in the literature soon to support my point of view.
Originally posted by: m...@mikesolomon.org
I think this patch is OK for countdown even in light of the potential feature Werner is talking about. It'd take 15 minutes of work to accidental-placement.cc and accidental-engraver.cc to allow the user to do what he's talking about - it'd just mean expanding the functionality of the accidentalGrouping property.
Originally posted by: lemzw...@googlemail.com
Great! Then please go ahead.
Originally posted by: dak@gnu.org
It is not clear whether comment #15 means "go ahead" with the proposed change in comment #14 or with this issue.
Put on countdown for 2013/01/25 17:00 UTC.
Labels: -Patch-review Patch-countdown
Owner: mts...@gmail.com
Status: Started
Originally posted by: lemzw...@googlemail.com
Sorry for being imprecise: I mean that this issue should be pushed to staging.
Originally posted by: dak@gnu.org
Countdown complete, please push.
Labels: -Patch-countdown Patch-push
Originally posted by: mts...@gmail.com
Pushed as [rb99bd638674b599f0ead29470b954e90d0d74e4a].
Werner - please open a new issue for accidentals in the same voice that are too far from chords. What'd be nice are scans from the literature showing how this is handled.
Labels: Fixed_2_17_11
Status: Fixed
Originally posted by: k-ohara5...@oco.net
A classic example of accidentals in octaves is in Beethoven Op13 (Sonate Pathéthique). In the first movement the climactic chord in the last Grave section (measure 297) has a D-flat octave in a chord containing suspended heads.
Lots of editions of the Beethoven let those flats misalign, which Ted Ross (p134) indicates as an allowable exception to the alignment rule, due to a suspended note-head affecting one of the octaves but not the other. The more studious editions, Godowsky and von Bülow, align them as LilyPond already does as shown in comment #12.
It certainly is easier to understand the accidentals if the octaves are aligned, especially for piano players.
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified
.