Menu
▾
▴
2 Attachments
#3088 Implement \undertie markup
Originally created by: *anonymous
Originally created by: dak@gnu.org
The given file has been sent to me by Jan, implementing undertied markups for LilyPond 2.14. It uses "bezier sandwich" stencils which, as far as I can tell, have been superseded and has various "FIXME" notices. While the example does run under current versions (see attached image) due to just copying the bezier sandwich definition, it would appear that this warrants a clean implementation (and integration into LilyPond) based on the currently approved graphical primitives.
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Labels: Type-Enhancement
Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie
issue 3088
In a follow up it is planned to replace make-parenthesis-stencil with
an appropiate setting of make-bow-stencil and to partially rework the
parenthesize-markup-command
http://codereview.appspot.com/270640043
Diff:
Passes make, make check and a full make doc.
Note that there are 'typos' that need correcting - see rietveld - but I am keeping this on 'review' for the 'code' changes.
fix typos and oversights
http://codereview.appspot.com/270640043
Passes make, make check and a full make doc.
Patch on countdown for November 10th
Comments on rietveld. Setting this back to review for now.
David's comments and other small rework
http://codereview.appspot.com/270640043
Passes make, make check and a full make doc.
This looks like it still needs some work - see comment on Rietveld.
Well, the last comments ended up only suggestions (while they were intended to further simplify the problem space significantly, they did not do that job but merely move the problem around). Whether Thomas considers this worth acting upon is pretty much up to him: it's only a matter of taste, not complexity, by now.
clean up/rework based on latest discussion
http://codereview.appspot.com/270640043
Passes make, make check and a full make doc.
sourceforge wasn't reachable from git-cl (I hope this was only temporary)
Thus manually, new patch is up:
make under/overtie robust against direction-modifiers, better foolproof for bow-stencil, more clean-up
https://codereview.appspot.com/270640043/