Patch: Remove "selective" contextmods.

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#2982 Patch: Remove "selective" contextmods.

Status: Verified

Owner: nobody

Labels: Fixed_2_17_9 (14)

Needs:

Patch:

Type: Maintainability

Updated: 2012-12-18

Created: 2012-11-26

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org

Remove "selective" contextmods.

This reverts those parts of commit
[r70365334614c31a82e9a3860c9eb9334cdc2879a] that have been responsible
for allowing context-mods to contain modifications restricted to
certain context types. It also removes use of this feature from
context-mod-from-music which is used for harvesting music into context
modifications.

As a result, any overrides in music used inside of context mods are
interpreted without looking at their actually targeted contexts. It
turned out that this "feature" offered more confusion than benefits.

http://codereview.appspot.com/6846107

Discussion

Google Importer - 2012-11-26

Originally posted by: dak@gnu.org

(No comment was entered for this change.)

Owner: dak@gnu.org

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-11-26

Originally posted by: dak@gnu.org

(No comment was entered for this change.)

Blocking: lilypond:2916

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-11-26

Originally posted by: dak@gnu.org

Patchy the autobot says: passes tests. No user-visible changes in the regtests.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-11-29

Originally posted by: ColinPKC...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-12-03

Originally posted by: ColinPKC...@gmail.com

Counted down to 20121203, please push before #2916.

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-12-04

Originally posted by: dak@gnu.org

(No comment was entered for this change.)

Blocking: -lilypond:2916

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-12-04

Originally posted by: dak@gnu.org

Pushed to staging as
commit [r6f14bc3f06c15ead9443df0e284eb87ed34c4fec]
Author: David Kastrup <dak@gnu.org>
Date:   Mon Nov 26 11:54:38 2012 +0100

    Remove "selective" contextmods.

    This reverts those parts of commit
    [r70365334614c31a82e9a3860c9eb9334cdc2879a] that have been responsible
    for allowing context-mods to contain modifications restricted to
    certain context types. It also removes use of this feature from
    context-mod-from-music which is used for harvesting music into context
    modifications.

    As a result, any overrides in music used inside of context mods are
    interpreted without looking at their actually targeted contexts. It
    turned out that this "feature" offered more confusion than benefits.

Labels: -Type-Enhancement -Patch-push Type-Maintainability Fixed_2_17_9
Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-12-18

Originally posted by: Elu...@gmail.com

(No comment was entered for this change.)

Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: