Menu
▾
▴
#2874 Patch: Provide an \undo function for turning overrides and sets into reverts and unsets
Originally created by: *anonymous
Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org
Provide an \un function for turning overrides and sets into reverts and unsets
Related
Discussion
Originally posted by: dak@gnu.org
Patchy the autobot says: passes tests.
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Owner: dak@gnu.org
Status: Started
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Summary: Patch: Provide an \undo function for turning overrides and sets into reverts and unsets
Originally posted by: dak@gnu.org
\undo\hideNotes is equivalent to \unHideNotes, \undo\easyHeadsOn to
\easyHeadsOff. While this can't undo reverts, it is useful for a lot
of overriding commands defined in ly/property-init.ly, and is also
useful in combination with \hide/\omit.
http://codereview.appspot.com/6588067
Labels: -Patch-countdown Patch-new
Originally posted by: dak@gnu.org
Patchy the autobot says: passes tests.
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: ColinPKC...@gmail.com
I may have missed marking this as patch-push on Tuesday. No, I'm not over the hill, but the view is rather fine up here!
Labels: -Patch-countdown Patch-push
Originally posted by: dak@gnu.org
Pushed to staging as
commit [r71eebe83138ead38e2e6383f6a9f145985e30b08]
Author: David Kastrup <dak@gnu.org>
Date: Wed Oct 3 13:38:24 2012 +0200
Issue 2874: Provide an \undo function for turning overrides and sets into re
\undo\hideNotes is equivalent to \unHideNotes, \undo\easyHeadsOn to
\easyHeadsOff. While this can't undo reverts, it is useful for a lot
of overriding commands defined in ly/property-init.ly, and is also
useful in combination with \hide/\omit.
After rethinking Janek's comments, it might make sense to let it warn specifically about any property-modifying commands it can't undo so that the user is not kept in the dark when the command will not fully succeed in its core area of operation, while at the same time ignoring non-property specific music contents silently. But that is something I have to think about and experiment some more. Separate issue, and other commands would warrant similar consideration.
Labels: -Patch-push Fixed_2_17_5
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified