Menu

#2873 Patch: Allow \shape to tweak music, swap its arguments

Verified
nobody
Enhancement
2012-10-06
2012-10-01
Anonymous
No

Originally created by: *anonymous

Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org

Allow \shape to tweak music, swap its arguments

Also does

Run scripts/auxiliar/update-with-convert-ly.sh

Add string-or-music? predicate

http://codereview.appspot.com/6585052

Discussion

  • Google Importer

    Google Importer - 2012-10-01

    Originally posted by: dak@gnu.org

    This is the change discussed in issue 2858 and/or on the developer list.

    Owner: dak@gnu.org
    Cc: david.na...@gmail.com tdanielsmusic
    Status: Started

     
  • Google Importer

    Google Importer - 2012-10-01

    Originally posted by: dak@gnu.org

    Patchy the autobot says: passes tests.  Various profiling changes, likely because of a different test order.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2012-10-01

    Originally posted by: pkx1...@gmail.com

    Patchy the autobot says: passes tests.

     
  • Google Importer

    Google Importer - 2012-10-02

    Originally posted by: ColinPKC...@gmail.com

    (No comment was entered for this change.)

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2012-10-04

    Originally posted by: ColinPKC...@gmail.com

    Counted down to 20121004, please push.

    Labels: -Patch-countdown Patch-push

     
  • Google Importer

    Google Importer - 2012-10-05

    Originally posted by: dak@gnu.org

    Pushed to staging as a merge commit (to avoid an invalid intermediate stage) as
    *   commit [r0f73eacc12dcfbb15688055ebfc3b3f71a5c266c]
    |\  Merge: 4424086 80abf95
    | | Author: David Kastrup <dak@gnu.org>
    | | Date:   Fri Oct 5 11:13:36 2012 +0200
    | |
    | |     Merge branch 'shape' into HEAD
    | |  
    | * commit [r80abf9548eaf68746f7dec28aeb43514c455c3bd]
    | | Author: David Kastrup <dak@gnu.org>
    | | Date:   Mon Oct 1 18:50:08 2012 +0200
    | |
    | |     Run scripts/auxiliar/update-with-convert-ly.sh
    | |  
    | * commit [r220f439edbd95266113248a984ebe6c4b97dcf14]
    |/  Author: David Kastrup <dak@gnu.org>
    |   Date:   Mon Oct 1 18:47:53 2012 +0200
    |  
    |       Allow \shape to tweak music, swap its arguments

    Labels: -Patch-push Fixed_2_17_4
    Status: Fixed

     
  • Google Importer

    Google Importer - 2012-10-05

    Originally posted by: dak@gnu.org

    Patch needed pushing again because Documentation/es/changes.tely contained an unconverted call of \shape.  Now it is
    *   commit [rc67137a4cf73e511f12f180e5e466af6e1863b04]
    |\  Merge: 8f113c7 72ced8a
    | | Author: David Kastrup <dak@gnu.org>
    | | Date:   Fri Oct 5 23:45:37 2012 +0200
    | |
    | |     Merge branch 'shape' into HEAD
    | |  
    | * commit [r72ced8a40db5db22998bce00a60ca8e6eef0bf33]
    | | Author: David Kastrup <dak@gnu.org>
    | | Date:   Fri Oct 5 23:44:34 2012 +0200
    | |
    | |     Run scripts/auxiliar/update-with-convert-ly.sh
    | |  
    | * commit [r0892e4cd4d8a4392ec789170fde721cefb18e1c7]
    |/  Author: David Kastrup <dak@gnu.org>
    |   Date:   Mon Oct 1 18:47:53 2012 +0200
    |  
    |       Allow \shape to tweak music, swap its arguments

     
  • Google Importer

    Google Importer - 2012-10-05

    Originally posted by: tdanielsmusic

    I was hoping the \tweak form of shape would work within chords,
    but it doesn't seem to - only the first tie here is modified:

    \relative c' {
      <<
        {
          <
            e-\shape #'((0 . 1) (0 . 1) (0 . 1) (0 . 1)) ~
            g-\shape #'((0 . 0.5) (0 . 2) (0 . 2) (0 . 0.5)) ~
          >1
          <e g>
        }
      \\
        { [r4] <g c,> <g c,> <g c,> }
      >>
    }

    Trevor

     
  • Google Importer

    Google Importer - 2012-10-06

    Originally posted by: Elu...@gmail.com

    (No comment was entered for this change.)

    Status: Verified

     
MongoDB Logo MongoDB