Menu

#2859 Patch: Provide \hide and \omit functions for transparent and void glyphs

Verified
nobody
Enhancement
2012-10-06
2012-09-26
Anonymous
No

Originally created by: *anonymous

Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org

Provide \hide and \omit functions for transparent and void glyphs

Both functions take either a grob name to override, or a music
expression to tweak (that is, the type of the argument decides whether
this results in an override or a tweak).

\hide sets #'transparent for the affected grob to ##t,
\omit sets #'stencil for the affected grob to ##f.

Example uses are
\new Voice \with { \omit StringNumber } { c'\4 }
{ <c' \hide g'~> g' }

Add string-or-music? predicate

http://codereview.appspot.com/6575048

Related

Issues: #2870

Discussion

  • Google Importer

    Google Importer - 2012-09-26

    Originally posted by: dak@gnu.org

    This was formerly part of issue 2717.

    Owner: dak@gnu.org
    Status: Started

     
  • Google Importer

    Google Importer - 2012-09-26

    Originally posted by: dak@gnu.org

    Patchy the autobot says: passes tests.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2012-09-27

    Originally posted by: ColinPKC...@gmail.com

    (No comment was entered for this change.)

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2012-09-28

    Originally posted by: dak@gnu.org

    (No comment was entered for this change.)

    Summary: Patch: Provide \hide and \no functions for transparent and void glyphs

     
  • Google Importer

    Google Importer - 2012-09-28

    Originally posted by: dak@gnu.org

    Provide \hide and \no functions for transparent and void glyphs

    Both functions take either a grob name to override, or a music
    expression to tweak (that is, the type of the argument decides whether
    this results in an override or a tweak).

    \hide sets #'transparent for the affected grob to ##t,
    \no sets #'stencil for the affected grob to ##f.

    Example uses are
    \new Voice \with { \no StringNumber } { c'\4 }
    { <c' \hide g'~> g' }

    Add string-or-music? predicate

    http://codereview.appspot.com/6575048

    Labels: -Patch-countdown Patch-new

     
  • Google Importer

    Google Importer - 2012-09-28

    Originally posted by: dak@gnu.org

    Provide \hide and \no functions for transparent and void glyphs

    Both functions take either a grob name to override, or a music
    expression to tweak (that is, the type of the argument decides whether
    this results in an override or a tweak).

    \hide sets #'transparent for the affected grob to ##t,
    \no sets #'stencil for the affected grob to ##f.

    Example uses are
    \new Voice \with { \no StringNumber } { c'\4 }
    { <c' \hide g'~> g' }

    Add string-or-music? predicate

    http://codereview.appspot.com/6575048

     
  • Google Importer

    Google Importer - 2012-09-28

    Originally posted by: dak@gnu.org

    Patchy the autobot says: passes tests.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2012-09-30

    Originally posted by: ColinPKC...@gmail.com

    (No comment was entered for this change.)

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2012-10-02

    Originally posted by: ColinPKC...@gmail.com

    There seems to be no agreement on Rietveld, so let's put this back to review.

    Labels: -Patch-countdown Patch-review

     
  • Google Importer

    Google Importer - 2012-10-03

    Originally posted by: dak@gnu.org

    To conclude the bikeshedding, an additional \un function has been provided in issue 2874 and \no has been renamed to \omit again, since \un\omit is less ugly than \un\no.

    Since this is holding up issue 2870, I would propose (after Patchy passes, of course) to change this back to Patch-countdown.  It's not like it has not seen extensive review.

    Summary: Patch: Provide \hide and \omit functions for transparent and void glyphs

     
  • Google Importer

    Google Importer - 2012-10-03

    Originally posted by: dak@gnu.org

    Issue 2859: Provide \hide and \omit functions for transparent and void glyphs

    Both functions take either a grob name to override, or a music
    expression to tweak (that is, the type of the argument decides whether
    this results in an override or a tweak).

    \hide sets #'transparent for the affected grob to ##t,
    \omit sets #'stencil for the affected grob to ##f.

    Example uses are
    \new Voice \with { \omit StringNumber } { c'\4 }
    { <c' \hide g'~> g' }

    Also:

    Add string-or-music? predicate

    http://codereview.appspot.com/6575048

    Labels: -Patch-review Patch-new

     
  • Google Importer

    Google Importer - 2012-10-03

    Originally posted by: dak@gnu.org

    Patchy the autobot says: passes tests.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2012-10-03

    Originally posted by: dak@gnu.org

    Putting this back on the countdown.  If there are additional objections, we can take it off again, but since there are also followup issues (work its uses into documentation and code), it seems like we have reached a state where it is seriously useful.  One obvious followup issue is to allow context specifications with the grobs, like \hide Staff.TimeSignature, and I am currently working on that.

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2012-10-04

    Originally posted by: ColinPKC...@gmail.com

    Counted down to 20121004, please push.

    Labels: -Patch-countdown Patch-push

     
  • Google Importer

    Google Importer - 2012-10-05

    Originally posted by: dak@gnu.org

    Well, here goes one round of bikeshedding, starting as issue 2717 over two months ago.  In the reviews, Keith gave an outlook to another series of bikeshedding for the corresponding reverts, but with any kind of luck, we can spend all that effort just on the single shed in issue 2874.  The required documentation issue has been outsourced to issue 2870, and frankly, while the names and uses were still oscillating, it did not make much sense working on it.

    At any rate, this particular one has now been pushed to staging as
    commit [r44240869b4d78df01ce4751fe7aae4b8d4e9d947]
    Author: David Kastrup <dak@gnu.org>
    Date:   Wed Sep 26 15:06:56 2012 +0200

        Issue 2859: Provide \hide and \omit functions for transparent and void glyph
       
        Both functions take either a grob name to override, or a music
        expression to tweak (that is, the type of the argument decides whether
        this results in an override or a tweak).
       
        \hide sets #'transparent for the affected grob to ##t,
        \omit sets #'stencil for the affected grob to ##f.
       
        Example uses are
        \new Voice \with { \omit StringNumber } { c'\4 }
        { <c' \hide g'~> g' }

    Labels: -Patch-push Fixed_2_17_4
    Status: Fixed

     
  • Google Importer

    Google Importer - 2012-10-06

    Originally posted by: Elu...@gmail.com

    (No comment was entered for this change.)

    Status: Verified

     
MongoDB Logo MongoDB