Menu
▾
▴
#2811 Patch: Uses horizontal skylines in accidental placement
Originally created by: *anonymous
Originally created by: mts...@gmail.com
Originally owned by: mts...@gmail.com
Uses horizontal skylines in accidental placement
Currently flats in 3rds and 4ths seem too snug, but everything
else seems OK. It gets rid of a lot of m4g1c numbers in
accidental-placement.cc.
Originally posted by: grenoui...@lilynet.net
Build results are available at
http://grenouille.lilynet.net/patches-tests/2811/test-results
20:56:13 (UTC) Begin LilyPond compile, previous commit at [r1092c0a96b39227cee9e51fb80d9518ad740cf1d]
20:56:20 Another instance (PID 31950) is already running.
21:26:28 Success: No new commits in master
21:27:43 Using test baseline from previous build.
21:27:43 Issue 2811: Patch: Uses horizontal skylines in accidental placement
21:27:43 Issue 2811: Testing patch issue6489086_1_diff
21:27:43 Success: sudo -u lilybuild git apply --index /home/jmandereau/lily-test-patches/issue6489086_1.diff
21:27:45 Success: sudo -u lilybuild ./autogen.sh --noconfigure
21:28:12 Success: sudo -u lilybuild /home/lilybuild/master/configure --disable-optimising
21:28:22 Success: sudo -u lilybuild nice make clean
21:44:16 Success: sudo -u lilybuild nice make -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1
22:09:20 Success: sudo -u lilybuild nice make check -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1
Related
Issues:
#2811Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes tests. Reg tests at https://www.yousendit.com/download/TEhVT2pOR0ZFc0lUWThUQw (5mb)
Labels: -Patch-new Patch-review
Originally posted by: mts...@gmail.com
Uses horizontal skylines in accidental placement
Currently flats in 3rds and 4ths seem too snug, but everything
else seems OK. It gets rid of a lot of m4g1c numbers in
accidental-placement.cc.
http://codereview.appspot.com/6489086
Labels: -Patch-review Patch-new
Originally posted by: janek.li...@gmail.com
Here's a nice regtest (attached, pdf results here: http://lilypond-stuff.1065243.n5.nabble.com/file/n5705605/accidental-spacing-pairs-new.pdf)
You may also want to look at issue 2141.
Related
Issues: #2141
Originally posted by: mts...@gmail.com
New patch buggy - will fix.
Labels: -Patch-new Patch-needs_work
Originally posted by: mts...@gmail.com
Uses horizontal skylines in accidental placement
Currently flats in 3rds and 4ths seem too snug, but everything
else seems OK. It gets rid of a lot of m4g1c numbers in
accidental-placement.cc.
http://codereview.appspot.com/6489086
Labels: -Patch-needs_work Patch-new
Originally posted by: mts...@gmail.com
Good to go for testing.
Originally posted by: grenoui...@lilynet.net
Build results are available at
http://grenouille.lilynet.net/patches-tests/2811/.
08:56:15 (UTC) Begin LilyPond compile, previous commit at [r2c00d625e88fb68342ac2fbaaffc6e8f9a182483]
08:56:23 From git.savannah.gnu.org:/srv/git/lilypond
2cc80f2..3cd2400 staging -> staging
08:56:23 Another instance (PID 26194) is already running.
09:26:31 Success: No new commits in master
09:26:36 Using test baseline from previous build.
09:26:36 Issue 2811: Patch: Uses horizontal skylines in accidental placement
09:26:36 Issue 2811: Testing patch issue6489086_6001_diff
09:26:37 *** FAILED BUILD ***
sudo -u lilybuild git apply --index /home/jmandereau/lily-test-patches/issue6489086_6001.diff
Previous good commit: [r2c00d625e88fb68342ac2fbaaffc6e8f9a182483]
Current broken commit: [r2c00d625e88fb68342ac2fbaaffc6e8f9a182483]
09:26:37 Error: issue 2811: Problem encountered
09:26:37 Traceback (most recent call last):
File "/home/jmandereau/lilypond-extra/patches/projecthosting_patches.py", line 275, in do_check
results_url = autoCompile.test_issue (issue_id, patch)
File "/home/jmandereau/lilypond-extra/patches/compile_lilypond_test/__init__.py", line 271, in test_issue
self.patch (patch, issue_id)
File "/home/jmandereau/lilypond-extra/patches/compile_lilypond_test/__init__.py", line 304, in patch
issue_id)
File "/home/jmandereau/lilypond-extra/patches/compile_lilypond_test/__init__.py", line 266, in runner
raise FailedCommand ("Failed runner: %s\nSee the log file %s" % (command, this_logfilename))
FailedCommand: Failed runner: sudo -u lilybuild git apply --index /home/jmandereau/lily-test-patches/issue6489086_6001.diff
See the log file log-2811-git-apply---index--home-jmandereau-lily-test-patches-issue6489086_6001.diff.txt
Related
Issues:
#2811Originally posted by: mts...@gmail.com
Uses horizontal skylines in accidental placement
Currently flats in 3rds and 4ths seem too snug, but everything
else seems OK. It gets rid of a lot of m4g1c numbers in
accidental-placement.cc.
http://codereview.appspot.com/6489086
Originally posted by: dak@gnu.org
Patchy the autobot says: Patch does not apply to current master. Fails in lily/time-signature.cc
Labels: -Patch-new Patch-needs_work
Originally posted by: mts...@gmail.com
Uses horizontal skylines in accidental placement
Currently flats in 3rds and 4ths seem too snug, but everything
else seems OK. It gets rid of a lot of m4g1c numbers in
accidental-placement.cc.
http://codereview.appspot.com/6489086
Labels: -Patch-needs_work Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes tests. Reg tests here: https://www.yousendit.com/download/TEhYeEVYTmFQb0tGa2NUQw (4.5mb)
Labels: -Patch-new Patch-review
Originally posted by: mts...@gmail.com
Uses horizontal skylines in accidental placement
Currently flats in 3rds and 4ths seem too snug, but everything
else seems OK. It gets rid of a lot of m4g1c numbers in
accidental-placement.cc.
http://codereview.appspot.com/6489086
Labels: -Patch-review Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes tests. Reg tests attached here: https://www.yousendit.com/download/TEhYeEVUb0JwTVVkVU1UQw (4.3mb)
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Owner: mts...@gmail.com
Status: Started
Originally posted by: mts...@gmail.com
Uses horizontal skylines in accidental placement
Currently flats in 3rds and 4ths seem too snug, but everything
else seems OK. It gets rid of a lot of m4g1c numbers in
accidental-placement.cc.
http://codereview.appspot.com/6489086
Labels: -Patch-review Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes tests. Reg tests here: https://www.yousendit.com/download/TEhXcmxRNDR6RThUWThUQw (4.3mb)
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: ColinPKC...@gmail.com
Counted down to 20120913, please push.
Labels: -Patch-countdown Patch-push
Originally posted by: mts...@gmail.com
Pushed as Grob *me = unsmob_grob (smob);
Grob *cause = unsmob_grob (me->get_property ("cause"));
if (!cause || !cause->is_live ())
{
me->suicide ();
return SCM_BOOL_F;
}
Labels: Fixed_2_17_3
Status: Fixed
Originally posted by: mts...@gmail.com
Meaning pushed as [r987fc85646498b0d8bfa89b85ad1375d942a53f0]
Need to work on my copying and pasting skills
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified
.