Menu
▾
▴
#2695 Bad output in display-lily-tests.ly
Originally created by: *anonymous
Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org
Our current source when run on display-lily-tests.ly produces
GNU LilyPond 2.15.42
Processing `input/regression/display-lily-tests.ly'
Parsing...
input/regression/display-lily-tests.ly:81:0: warning: Test unequal: BUG.
in = { \appoggiatura c8 d2 }
out = { \grace { { < >( } c8 { < >) } } d2 }
\test ##[ { \appoggiatura c8 d2 } #]
input/regression/display-lily-tests.ly:82:0: warning: Test unequal: BUG.
in = { \acciaccatura c8 d2 }
out = { \grace { { < >( \override Flag #'stroke-style = #"grace"
} c8 { \revert Flag #'stroke-style
< >) } } d2 }
\test ##[ { \acciaccatura c8 d2 } #]
This kind of change should have been caught by the test-patches team before getting checked in. I am investigating when it was introduced.
Perhaps display-lily-test.ly should move from producting warnings to producing errors to avoid this in future?
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Labels: Type-Defect Regression
Owner: dak@gnu.org
Originally posted by: dak@gnu.org
Ok, the bad commit is
[r4ab6e4df934e57c51dbbdbf2c209273c6cb5b888] is the first bad commit
commit [r4ab6e4df934e57c51dbbdbf2c209273c6cb5b888]
Author: Keith OHara <k-ohara5a5a@oco.net>
Date: Wed May 9 18:42:59 2012 -0700
Doc: avoid using zero-duration spacers in examples
:040000 040000 [r2dd3401220344d3025b9cc12f546bf62f22c716e] [rd3618ac4379ef5e8b57680d6b72c8ee9ed9f8082] M Documentation
:040000 040000 [ra766d366d3b836aabdb204a03e67dc46f1d81152] [r65c8ea04789bd8f5cf6bd41feac07d345664317b] M input
:040000 040000 [r07b2655269433b2b8c8d7b2c6bab96bd8e8c617b] [r4af8c1da1f683f822b90e31560d02f6cbf8be35f] M ly
Now on to fixing it.
Status: Started
Originally posted by: dak@gnu.org
Issue 2695: Bad output in display-lily-tests.ly
This fixes a bug introduced with [r4ab6e4df934e57c51dbbdbf2c209273c6cb5b888]
while addressing issue 2522.
http://codereview.appspot.com/6451045
Labels: Patch-new
Originally posted by: dak@gnu.org
Patchy the autobot says: passes tests.
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
Pushed straight to staging after passing tests (reasonably trivial regression fix) as
commit [re2853fe82389af7e0a21bce0262b6453e3430614]
Author: David Kastrup <dak@gnu.org>
Date: Wed Jul 25 16:52:15 2012 +0200
Issue 2695: Bad output in display-lily-tests.ly
This fixes a bug introduced with [r4ab6e4df934e57c51dbbdbf2c209273c6cb5b888]
while addressing issue 2522.
Labels: -Patch-review Fixed_2_15_42
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified