Menu
▾
▴
#2664 stringTunings snippet in NR 2.4.1
Originally created by: *anonymous
Originally created by: colingh...@gmail.com
Originally owned by: dak@gnu.org
Federico Bruni reported here:
http://lists.gnu.org/archive/html/bug-lilypond/2012-07/msg00079.html
http://old.nabble.com/stringTunings-snippet-in-NR-2.4.1-to34164440.html
http://article.gmane.org/gmane.comp.gnu.lilypond.bugs/35831
Federico reported a problem and also included a patch to fix it. See original post for a copy of the patch.
Text of original bug report follows:
------------------------
As you can see in the image here:
http://lilypond.org/doc/v2.15/Documentation/notation/common-notation-for-fretted-strings#index-stringTuning-1
TabStaff displays 6 strings while the snippet is intended for a 4 string instrument.
I guess that stringTunings should specify the TabStaff context.
As it's a trivial change, I attach a patch.
--
Federico
------------------------
Cheers,
Colin.
Discussion
Gen AI apps are built with MongoDB Atlas
Atlas offers built-in vector search and global availability across 125+ regions. Start building AI apps faster, all in one place.
Originally posted by: dak@gnu.org
git blame says
3170fd65 Documentation/notation/fretted-strings.itely (David Kastrup 2011-10-23 15:29:45 +0200 586) \set stringTunings = \stringTuning <c' g' d'' a''>
and it turns out that many of the \set stringTunings commands have been set by a convert-ly rule which would need fixing. Replacing them with \set TabStaff.stringTunings in general would probably not help with FretBoards.
Perhaps one needs an alias "Fretted" or something for both TabStaff and FretBoards, so that \set Fretted.stringTunings works in either? Or do they already listen to a common alias? Staff maybe?
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Owner: dak@gnu.org
Status: Started
Originally posted by: dak@gnu.org
Issue 2664: stringTunings snippet in NR 2.4.1
This fixes an unfortunate convertrule that used
\set stringTuning = ...
which sets the string tuning in the current Bottom context. Which
does not work in a TabStaff.
This is followed by the following commits rehashing the convertrule
operation:
Revert "Run update-with-convert-ly"
This reverts commit [r0d0a674ba7bfa052e277861427c0a2d7a6d2cdde].
Conflicts:
Documentation/de/notation/fretted-strings.itely
Documentation/es/notation/fretted-strings.itely
Rerun update-with-convert-ly
When committed, the whole kaboodle will be done as one merge commit.
Translators will likely doing their readers a favor by hand-polishing
the results of the automatic conversion.
http://codereview.appspot.com/6425061
Labels: Patch-new
Originally posted by: dak@gnu.org
Patchy wanted to say: passes tests (but the web API seems to be readonly still).
Regtest context-string-tuning is now showing only four stafflines, but the same fingerings. The previous behavior assigned the right fingerings at voice level, but at staff level did not see the tuning and used a wrong number of stafflines. Strange that this managed to pass regtest comparisons first time round.
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
This is an alternative fix to issue 2664. It assigns a "Staff" alias
to FretBoards (which is also reasonable for things like
instrumentName, less so for clefs and similar folderol) and generally
uses \set Staff.stringTuning instead of \set stringTuning. It could
also be applied on top of the other fix on review (of course, with a
different result from running update-with-convert-ly.sh committed).
The advantage of using this commit alone for a fix is consistent use
of Staff.stringTuning. The disadvantage is that conversions to
versions between 2.15.10 and 2.15.41 will continue being defective.
However, you would still require a post-2.15.41 convert-ly to fix
that, and the conversion results would be less consistent, and the
conversion rule is more complex. Since it is unlikely that conversion
to the middle of the 2.15 range will be so important in future as to
make people employ a post-2.15.41 convert-ly for that purpose, I lean
towards using this simpler fix on its own. It also catches problems
more thoroughly than the previous fix. While it would still do so
when used for sweeping after the other fix, we's get a mixture of
overrides to Staff.stringTuning, FretBoards.stringTuning and
TabStaff.stringTuning.
So barring more convincing arguments, I would likely proceed with
using just _this_ fix on its own.
Commits:
Add Staff alias to FretBoards, let convert-ly set Staff.stringTuning
Run scripts/auxiliar/update-with-convert-ly.sh
http://codereview.appspot.com/6438043
Labels: -Patch-review Patch-new
Originally posted by: dak@gnu.org
Patchy the autobot says: passes tests. The expected change in context-string-tuning.ly. It would probably be reasonable to check that the _reported_ issue in the docs is successfully changed.
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
Well, the docs look fine as far as I can tell.
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Labels: -Type-Documentation Type-Critical Regression
Originally posted by: ColinPKC...@gmail.com
Counted down to 20120726, please push
Labels: -Patch-countdown Patch-push
Originally posted by: dak@gnu.org
Pushed to staging (after rebasing and rerunning update-with-convert-ly) as
commit [r0a02dad4e693f068c235fd44647cc03ebe2af5ec]
Author: David Kastrup <dak@gnu.org>
Date: Fri Jul 27 07:26:27 2012 +0200
Issue 2664/2: Run scripts/auxiliar/update-with-convert-ly.sh
commit [r08e0e65cb2905bfe9ded5407662d9af3b0b99283]
Author: David Kastrup <dak@gnu.org>
Date: Tue Jul 24 08:22:11 2012 +0200
Issue 2664: Add Staff alias to FretBoards, let convert-ly set Staff.stringTu
Labels: -Patch-push Fixed_2_15_42
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified