LilyIssues / Issues / #2613 Patch: add general_alignment method (Rietveld 6308093)

Google Importer - 2012-06-19

Originally posted by: janek.li...@gmail.com

here's the Rietveld issue:

http://codereview.appspot.com/6308093

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-19

Originally posted by: janek.li...@gmail.com

Attached is a demonstration showing how this patch works.

alignment-demonstration.ly

alignment-demonstration.pdf

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-19

Originally posted by: ColinPKC...@gmail.com

Patchy the autobot says: Fails in doc build: Database file #1: /home/patchy/lilypond-autobuild/Documentation/web/others-did.bib
Running bibtex on /home/patchy/lilypond-autobuild/Documentation/web/others-did
TEXMFOUTPUT=/tmp bibtex /tmp/tmpRl4VrZbib2texi

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-19

Originally posted by: gra...@percival-music.ca

That is highly suspicious. Could you double-check that you haven't run out of disk space or something like that?

I'm setting this back to Patch-new so that somebody else can test it, because I totally don't see how that patch could produce this result.

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-19

Originally posted by: janek.li...@gmail.com

Thanks, Colin and Graham!
However, i should've marked this as patch-needs_work because it's a draft (it should work, but it isn't finished). Actually, patch-waiting seems to be an even better option (i didn't notice we've introduced that label, sorry!).
Of course feel free to test it if you want!
I'd also greatly appreciate any comments - for example about the results shown in pdf above.

Labels: -Patch-new Patch-waiting

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-19

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Blocking: lilypond:2451

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-19

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Blocking: lilypond:2452

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-19

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Blocking: lilypond:2461

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-21

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Summary: Patch: add general_alignment method (Rietveld 6308093)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-21

Originally posted by: janek.li...@gmail.com

This adds a versatile method for specifying alignment of grobs, allowing parent reference point to be specified separately from grob reference point.

http://codereview.appspot.com/6308093

Labels: -Patch-waiting Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-21

Originally posted by: janek.li...@gmail.com

(and it should compile and pass regtests now)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-21

Originally posted by: janek.li...@gmail.com

And updated example, showing how to use scheme callbacks provided for general_alignment.

alignment-demonstration%20new.pdf

alignment-demonstration.ly

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-21

Originally posted by: dak@gnu.org

Patchy the autobot says: Fails "make" when trying to generate the internals documentation.

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-21

Originally posted by: dak@gnu.org

Maybe it would be worthwhile running "make" before uploading? It does not take all that much time. Certainly less so than a full Patchy run.

A doc string in define-grob-properties.scm contains {@code{-1}}, namely braces unconnected to any control sequence.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-22

Originally posted by: janek.li...@gmail.com

David,

i'm very sorry that this happened. It's my fault; i had ran make to check c++ code, but hadn't checked again after adding changes in docstrings. I should've known
better since it's not the first time that docstrings bit me.
I apologise for wasting your time.
I also want to thank you for taking the time to show me the mistakes i did. It's very kind of you, especially considering that you're correcting my own sloppiness - the very one that caused the waste of your time.

Finally, to quote a developer that i hold in high esteem, let me express my appreciation that you don't offload the onus of testing to the person running Patchy, making sure that all your patches pass the test yourself. I shall follow your lead in this respect.

There's a new version of the patch at http://codereview.appspot.com/6308093/
It passes make; i'll check regtests later so now i'm just setting its status to patch-waiting.

Labels: -Patch-needs_work Patch-waiting

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-07-08

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Status: done

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-07-14

Originally posted by: PhilEHol...@googlemail.com

Don't see any statement that this has been pushed, so resetting it to Accepted.

Status: Accepted

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-13

Originally posted by: pkx1...@gmail.com

This won't pass muster on the reg tests this old.

Setting back to needs_work

Labels: -Patch-waiting Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-18

Originally posted by: janek.li...@gmail.com

This issue has morphed into issue 3239.
I'm closing this Rietveld issue (https://codereview.appspot.com/6308093/).

Labels: -Type-Enhancement -Patch-needs_work
Mergedinto: 3239
Status: Duplicate

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-07

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Blocking: -lilypond:2451

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-07

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Blocking: -lilypond:2452

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Patch: add general_alignment method (Rietveld 6308093)

Issue Tracker for LilyPond

Searches

Help

#2613 Patch: add general_alignment method (Rietveld 6308093)

Discussion