Menu

#2540 Patch: Give \tweak an optional grob parameter for tweaking indirect grobs

Verified
nobody
Critical
2012-05-24
2012-05-18
Anonymous
No

Originally created by: *anonymous

Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org

Give \tweak an optional grob parameter for tweaking indirect grobs

You can now use something akin to

  \tweak Accidental #'color #red cis'

for tweaking a grob created indirectly from the given music expression.

http://codereview.appspot.com/6211063

Related

Issues: #2536
Issues: #2539

Discussion

  • Google Importer

    Google Importer - 2012-05-18

    Originally posted by: dak@gnu.org

    Again, I have no good idea how to juggle priorities, status and other here: I have split this issue out from issue 2536 since it is actually separate (and now has a user interface to boot).  Since it will get pushed as part of 2536 which is on countdown (I'll interrupt the countdown for getting the user interface aspect of _this_ issue tested by test-patchy, but will let it resume afterwards), this issue technically blocks 2536 and, being part of it, should be on the same countdown.

    It only contains command docs; actual manual changes remain as separate work, and I'll try incorporating them into issue 2539 directly, to be done afterwards.

    Labels: -Type-Enhancement Type-Critical
    Owner: dak@gnu.org
    Status: Started

     
  • Google Importer

    Google Importer - 2012-05-18

    Originally posted by: dak@gnu.org

    Patchy the autobot says: passes tests.  Lookup of 'tweaks on events more than quadruples (since indirect grobs also look there), lookup of 'cause on grobs increases about 10%.  Other than that, no changes.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2012-05-18

    Originally posted by: dak@gnu.org

    Put on countdown, since its changes are part of those of issue 2536 and thus any last-minute reviews or comments are just as urgent.

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2012-05-20

    Originally posted by: dak@gnu.org

    Give \tweak an optional grob parameter for tweaking indirect grobs

    You can now use something akin to

      \tweak Accidental #'color #red cis'

    for tweaking a grob created indirectly from the given music expression.

    http://codereview.appspot.com/6211063

    Labels: -Patch-countdown Patch-new

     
  • Google Importer

    Google Importer - 2012-05-20

    Originally posted by: dak@gnu.org

    Patchy the autobot says: passes tests.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2012-05-20

    Originally posted by: dak@gnu.org

    (No comment was entered for this change.)

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2012-05-20

    Originally posted by: ColinPKC...@gmail.com

    Counted down to 20120520, please push

    Labels: -Patch-countdown Patch-push

     
  • Google Importer

    Google Importer - 2012-05-20

    Originally posted by: dak@gnu.org

    Pushed as
    commit [r73d3a7eacc32f58d4c0215709652bd4470243321]
    Author: David Kastrup <dak@gnu.org>
    Date:   Sun May 20 20:20:13 2012 +0200

        Add regression tests and display routines for tweaking of named grobs.

    commit [r0b716515bfd610a04bbe4289f171f3cd80a0fc14]
    Author: David Kastrup <dak@gnu.org>
    Date:   Tue May 15 19:11:03 2012 +0200

        Give \tweak an optional grob parameter for tweaking indirect grobs
       
        You can now use something akin to
       
          \tweak Accidental #'color #red cis'
       
        for tweaking a grob created indirectly from the given music expression.

    to staging.

    Labels: -Patch-push Fixed_2_15_39
    Status: Fixed

     
  • Google Importer

    Google Importer - 2012-05-24

    Originally posted by: Elu...@gmail.com

    superb!

    Status: Verified

     
  • Google Importer

    Google Importer - 2012-05-24

    Originally posted by: dak@gnu.org

    I have to admit to being flattered by this rather uncommon outbreak of enthusiasm.

     
  • Google Importer

    Google Importer - 2012-05-24

    Originally posted by: Elu...@gmail.com

    makes life (using Lilypond) much easier!