Menu
▾
▴
1 Attachments
#2532 regression - hairpins begin/end in wrong places (incorrect spanner bounds)
Originally created by: *anonymous
Originally created by: janek.li...@gmail.com
Originally owned by: mts...@gmail.com
\markup "hairpins attached to notes with arpeggios begin too early:"
\markup "(this is a regression against 2.14.2)"
{ <cis' cis''>1\arpeggio \< c'\! }
\markup "this is especially visible with cross-staff arpeggios:"
\markup "(this is a regression against 2.14.2)"
\new PianoStaff<<
\set PianoStaff.connectArpeggios = ##t
{ c''\arpeggio \< c''\! }
{ c'\arpeggio c'' }
>>
\markup "The situation is exactly the same when Dynamic context with spacers is used:"
\markup "(this is a regression against 2.15.9)"
\new PianoStaff<<
\set PianoStaff.connectArpeggios = ##t
{ c''\arpeggio c'' }
\new Dynamics { s\< s\! }
{ c'\arpeggio c'' }
>>
\markup "There are also problems with lyrics:"
\markup "(this is a regression against 2.15.9)"
<<
\new Staff { b4 b4~ b4 b4 }
\addlyrics{ x looooooooong x }
\new Staff { << b1 { s4\< s4\! s4\> s4\! } >> }
>>
Originally posted by: mts...@gmail.com
Hey Janek,
I have time to git bisect today (stuffing envelopes). Will keep you posted.
Cc: -joenee...@gmail.com k-ohara5...@oco.net
Originally posted by: mts...@gmail.com
Culprit found - on it.
[ra00fa3d9a28af688cf3bf3dcc8636f2e0cb39117] is the first bad commit
commit [ra00fa3d9a28af688cf3bf3dcc8636f2e0cb39117]
Author: Mike Solomon <mike@apollinemike.com>
Date: Fri Feb 10 08:30:01 2012 +0100
Implements bound-alignment-interfaces for NonMusicalPaperColumn.
This includes all grobs save break-alignable grobs usch as
MetronomeMark and RehearsalMark.
:040000 040000 [r0cfd752d202c7fcc89234c9d0a0da3d5eb03fee6] [r4b4e2e737bfaff841de3accaa38d5dfa0e7b0984] M input
:040000 040000 [r79823e9ac06d44e01f70589274957a4432759760] [r90f9daea0e2407a502be6fa001364c6a6f220590] M lily
:040000 040000 [r1fd027570d17a6bdff8d764ca6e52119a07d7b46] [rb3b7ac19511088b518c41d5e5dfe51d01c3bca17] M scm
Originally posted by: mts...@gmail.com
Correctly handles bounds of spanners that are PaperColumns
http://codereview.appspot.com/6206061
Labels: Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: LGTM.
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
(No comment was entered for this change.)
Owner: mts...@gmail.com
Cc: -mts...@gmail.com
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-countdown Patch-push
Originally posted by: k-ohara5...@oco.net
Appears to be fixed in master. Probably [r8acad65978d6a5efc174b07d61147028a0c1d3a6]
Labels: fixed_2_15_39
Cc: -k-ohara5...@oco.net
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified
.