Menu
▾
▴
#2518 Patch: Make \footnote a post-event
Invalid
nobody
None
Enhancement
2012-05-25
2012-05-06
Anonymous
No
Originally created by: *anonymous
Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org
Make \footnote a post-event
Also run scripts/auxiliar/update-with-convert-ly.sh
The result should work, but for sanity's sake, this should be followed
by a manual conversion of all occurences of
<>\footnote ...
note-or-chord
into
note-or-chord\footnote ...
It would have been too error-prone to try detecting a suitable
note-or-chord sequence to move across automatically.
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Owner: dak@gnu.org
Status: Started
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Blocking: 2505
Originally posted by: dak@gnu.org
Make \footnote a post-event
Also run scripts/auxiliar/update-with-convert-ly.sh
The result should work, but for sanity's sake, this should be followed
by a manual conversion of all occurences of
<>\footnote ...
note-or-chord
into
note-or-chord\footnote ...
It would have been too error-prone to try detecting a suitable
note-or-chord sequence to move across automatically.
http://codereview.appspot.com/6203044
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: LGTM. Although there are lots of 'extra' log output that shows up and I never know if it is good or bad. I don't see 'errors' or 'warnings' just the '+' and '-' entries and the 'cells' values change - some go up some go down. I guess that's all ok.
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
Basically, if the numbers get smaller overall, that's a good sign (relative changes in parens are nice if positive, naughty if negative). Large jumps in unrelated tests tend to be build system noise. Some regtest outputs change all the time (like those for graphviz, and the properties are also quite variable).
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: ColinPKC...@gmail.com
Counted down to 20120510, please push
Labels: -Patch-countdown Patch-push
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Blocking: -2505
Originally posted by: dak@gnu.org
Pushed as one merge commit to staging:
* commit [r2ec0cd55d55c49dee4e5604903dfab8ff4a089c4] (HEAD, origin/staging)
|\ Merge: 0a0274a 9ec7c79
| | Author: David Kastrup <dak@gnu.org>
| | Date: Fri May 11 12:20:01 2012 +0200
| |
| | Merge branch 'footnote' into HEAD
| |
| * commit [r9ec7c79078944a94e2e9abbf8e1b3299c9706389] (footnote)
| | Author: David Kastrup <dak@gnu.org>
| | Date: Sun May 6 22:01:28 2012 +0200
| |
| | Run scripts/auxiliar/update-with-convert-ly.sh
| |
| * commit [r94c0a1343826f84fc78006d07f6ed92e82b6ec02]
|/ Author: David Kastrup <dak@gnu.org>
| Date: Sun May 6 20:53:51 2012 +0200
|
| Make \footnote a post-event
|
Labels: -Patch-push Fixed_2_15_39
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified
Originally posted by: dak@gnu.org
Actually, this has been reverted as of
commit [r4a81b4d1f1706e503b0bb8fd7c80be3c825cc96c]
Author: David Kastrup <dak@gnu.org>
Date: Tue May 15 11:55:28 2012 +0200
Revert "Merge branch 'footnote' into HEAD"
This reverts commit [r2ec0cd55d55c49dee4e5604903dfab8ff4a089c4], reversing
changes made to [r0a0274a3bf5792dfb7ce3719f5dfaef36059affe].
Since the original request is no longer in place and there has not been an actual release with this code, I am marking this "Invalid" (in lack of anything better fitting) instead of verified.
This has been superseded by issue 2536, implementing yet another (but definitely less cumbersome) interface.
Labels: -Fixed_2_15_39
Status: Invalid