Menu
▾
▴
#2480 hideNotes and unHideNotes should include also TabNoteHead
Originally created by: *anonymous
Originally created by: fedel...@gmail.com
Originally owned by: fedel...@gmail.com
Enhancement request: hideNotes should hide also the numbers in TabStaff.
It was not straightforward in the past, because unHideNotes reverted the visibility of some objects (such as stems) that must not be displayed in default tablature:
http://lists.gnu.org/archive/html/lilypond-user/2010-01/msg00634.html
But now the output is correct. Marc thinks that some patches according stems and the placement of tablature numbers may have had the side effect of fixing this problem:
http://lists.gnu.org/archive/html/lilypond-user/2012-04/msg00231.html
As issue 1459 is fixed, hideNotes looks ok also in TabStaff.
I think that we should add one line to the following definitions in property-init.ly:
hideNotes = {
....
\override TabNoteHead #'transparent = ##t
}
unHideNotes = {
...
\revert TabNoteHead #'transparent
}
You can test this change by compiling the file Documentation/snippets/new/slides-in-tablature.ly
If we change this definition, the following LSR snippet can be removed as soon as LSR upgrades to 2.16:
http://lsr.dsi.unimi.it/LSR/Item?id=633
Originally posted by: fedel...@gmail.com
Ok, I won't be shy: find patch attached.
Labels: Type-Patch
Owner: fedel...@gmail.com
Cc: m...@hohlart.de
Status: Started
Originally posted by: ColinPKC...@gmail.com
As this is a very small patch, let's put it straight onto countdown. It was created without using lily-git or git-cl, so there is no Rietveld issue.
Labels: Patch-countdown
Originally posted by: k-ohara5...@oco.net
> You can test this change by compiling the file Documentation/snippets/new/slides-in-tablature.ly
It is worth mentioning that this snippet is not new, but already in the 2.14 manuals, where it currently looks wrong. This patch will change image of that snippet to the (correct) version attached.
Originally posted by: gra...@percival-music.ca
also note that the file Documentation/snippets/new/slides-in-tablature.ly is no longer in D/S/n and (correctly) only appears in D/s now.
Originally posted by: fedel...@gmail.com
I've just realized that the tablature example uses a function that we can now replace with \hideNotes.
Find patch attached
Originally posted by: gra...@percival-music.ca
ok, now this is too much. Please use git-cl to create a rietveld issue and change this to Patch-new.
Labels: -Patch-countdown Patch-needs_work
Originally posted by: fedel...@gmail.com
Ok, I've just downloaded and configured git-cl.
Should I create a single patch containing changes in (both) property-init.ly and tab-example.ly?
Originally posted by: gra...@percival-music.ca
For absolute correctness, keep both patches as separate (in a local branch). When you run git-cl, it will upload both patches in the same bundle, but that's ok. After the combination goes through the patch review process, they will be pushed as two separate patches.
Originally posted by: dak@gnu.org
git-cl converts everything into a single patch anyway. You keep your changes organized logically in commits as you see fit (and submit them in that manner once the result passed review and countdown). However, for the sake of bisection, every single commit should properly build, compile and work out. While we do not explicitly check this (only the overall result of the change is tested), you should try your best to make it so.
Originally posted by: fedel...@gmail.com
hideNotes should hide also TabNoteHead (issue 2480).
Tablature example updated accordingly.
http://codereview.appspot.com/6105049
Labels: -Patch-needs_work Patch-new
Originally posted by: fedel...@gmail.com
http://codereview.appspot.com/6105049
I had to make the commits from scratch (in a nutshell, because of the way I'm used to work in the lilypond/translation branch)
Originally posted by: dak@gnu.org
Patchy the autobot says: LGTM.
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: ColinPKC...@gmail.com
Comments on Rietveld from Neil and Keith
Labels: -Patch-countdown Patch-needs_work
Originally posted by: fedel...@gmail.com
hideNotes should hide also TabNoteHead (issue 2480).
Tablature example updated accordingly.
http://codereview.appspot.com/6105049
Labels: -Patch-needs_work Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: LGTM.
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: ColinPKC...@gmail.com
Counted down to 20120429, please push and close the Rietveld issue http://codereview.appspot.com/6105049
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-countdown Patch-push
Originally posted by: fedel...@gmail.com
I don't have push ability, please someone push it for me.
I'll close the Rietveld issue.
Thanks
Originally posted by: ColinPKC...@gmail.com
@Bruno: I believe you have an account on savannah, listed as a contributor to lilypond. The user ID was added to the lilypond group in January, 2010 and doesn't use a gmail address. I'm being cautiously vague, but I think you may have forgotted an old address. If all else fails, you can simply send me a formatted patch, and I'll see if I can push it for you.
Originally posted by: fedel...@gmail.com
Find patch attached and thanks for pushing it for me.
I had to make it again because I've started playing with branches recently and messed up the previous commits. It's a single patch instead of two, but it's ok (Keith was in favour of a single patch).
Yes, brunology is an account of mine, but I'm not using that email anymore and I've lost the login password. I've made a request for inclusion for my new account (fedelibre).
Originally posted by: ColinPKC...@gmail.com
Pushed to staging as [r2817ef1228cecd8b275fd666e0b5ba1bbd9406ce]
Labels: -Patch-push Fixed_2_15_38
Status: Fixed
Originally posted by: ma...@gregoriana.sk
(No comment was entered for this change.)
Status: Verified