Menu

#2232 (de)crescendo terminated with (de)crescendo doesn't affect midi volume

Verified
Dan Eble
Defect
2016-06-27
2012-01-19
Anonymous
No

Originally created by: *anonymous

Originally created by: pkx1...@gmail.com

PrzemysławPawełczyk via gnu.org

to bug-lilypond
Hello.

I spotted this bug 2 months ago. Was easy to workaround, so I forgot to
notify about it. Affects both stable and dev branch.

%\version "2.14.2"
\version "2.15.26"

global = { \key c \major \time 4/4 }
rightHand = \relative c' { \clef treble c8 d e f g a b c \bar "|." }

dynamics = { s4\p\< s4 s4\> s8 s8\! }
% crescendo doesn't work in midi unless it's terminated with explicit \!
% (like the following decrescendo here)
% there is no problem if you use absolute dynamic to terminate, though

\score {
  \new PianoStaff = "piano" <<
    \new Staff = "up" << \global \dynamics \rightHand >>
  >>
  \midi {}
}

Discussion

  • Google Importer

    Google Importer - 2015-07-20

    Originally posted by: simon.al...@mail.de

    (No comment was entered for this change.)

    Summary: (de)crescendo terminated with (de)crescendo doesn't affect midi volume

     
  • Dan Eble

    Dan Eble - 2016-06-05
    • Description has changed:

    Diff:

    
    
    • assigned_to: Dan Eble
    • Needs: -->
    • Patch: -->
     
  • Dan Eble

    Dan Eble - 2016-06-06

    Issue 2232: fix MIDI output of abutting (de)crescendi

    http://codereview.appspot.com/300300043

     
  • David Kastrup

    David Kastrup - 2016-06-06
    • status: Accepted --> Started
    • Needs: -->
    • Type: -->
     
  • Anonymous

    Anonymous - 2016-06-06
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-06-06

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-06-09
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-06-09

    Patch on countdown for June 12

    Dan do we need a changes.tely entry for this?

    It looks like something that has changed but I am not proficient enough to know if a user would notice or if the user now has additional/different functionality that needs documenting.

     
  • Anonymous

    Anonymous - 2016-06-12
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-06-12

    Patch counted down - please push.

    Dan if we need to do something in 'Changes' can you add a tracker so it doesn't get forgotten?

     
  • Dan Eble

    Dan Eble - 2016-06-13

    I don't think this bug-fix is significant enough to mention.

     
  • Dan Eble

    Dan Eble - 2016-06-14
    • labels: --> Fixed_2_19_44
    • status: Started --> Fixed
    • Patch: push -->
    • Type: Enhancement --> Defect
     
  • Federico Bruni

    Federico Bruni - 2016-06-27
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -7,24 +7,25 @@
     to bug-lilypond 
     Hello.
    
    -I spotted this [bug 2](#2) months ago. Was easy to workaround, so I forgot to
    +I spotted this bug 2 months ago. Was easy to workaround, so I forgot to
     notify about it. Affects both stable and dev branch.
    
    -
    +~~~~
     %\version "2.14.2"
     \version "2.15.26"
    
    -global = \{ \key c \major \time 4/4 \}
    -rightHand = \relative c' \{ \clef treble c8 d e f g a b c \bar "|." \}
    +global = { \key c \major \time 4/4 }
    +rightHand = \relative c' { \clef treble c8 d e f g a b c \bar "|." }
    
    -dynamics = \{ s4\p\&lt; s4&nbsp; s4\&gt; s8 s8\\\! \}
    -% crescendo doesn't work in midi unless it's terminated with explicit \\\!
    -% \(like the following decrescendo here\)
    +dynamics = { s4\p\< s4 s4\> s8 s8\! }
    +% crescendo doesn't work in midi unless it's terminated with explicit \!
    +% (like the following decrescendo here)
     % there is no problem if you use absolute dynamic to terminate, though
    
    -\score \{
    -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \new PianoStaff = "piano" &lt;&lt;
    -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \new Staff = "up" &lt;&lt; \global \dynamics \rightHand&nbsp; &gt;&gt;
    -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &gt;&gt;
    -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \midi \{ \}
    -\}
    +\score {
    +  \new PianoStaff = "piano" <<
    +    \new Staff = "up" << \global \dynamics \rightHand >>
    +  >>
    +  \midi {}
    +}
    +~~~~
    
    • status: Fixed --> Verified
     

    Related

    Issues: #2

  • Federico Bruni

    Federico Bruni - 2016-06-27

    f4e12f1b0cb5dfb32f193f87e7ca28c406b87771

     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.