Menu
▾
▴
#2230 add svg regtests
Accepted
nobody
None
abandoned
Enhancement
2012-09-03
2012-01-18
Anonymous
No
Originally created by: *anonymous
Originally created by: mts...@gmail.com
Currently, the regtests cannot test svg files. They should be able to, ideally in a svg folder in input/regression. This would require compiling each file separately and without using lilypond-book (at least in lilypond-book's current form).
Originally posted by: julien.r...@gmail.com
Add regtest directory for svg output (issue 2230).
http://codereview.appspot.com/5815043
Labels: Patch-new
Originally posted by: julien.r...@gmail.com
(No comment was entered for this change.)
Owner: julien.r...@gmail.com
Cc: mts...@gmail.com
Status: Started
Originally posted by: mts...@gmail.com
The innards of the patch are way over my head, but this is way cool! It'll allow me to finally do some checks on various things in the SVG output, especially with IDs.
Originally posted by: julien.r...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-new Patch-needs_work
Originally posted by: dak@gnu.org
Patchy the autobot says: Trying 2230 with /usr/local/tmp/lilypond/issue5815043_1.diff
Problem with issue 2230
Failed runner: nice make check -j3
See the log file log-2230-nice-make-check--j3.txt
/usr/local/tmp/lilypond/issue5815043_1.diff:26: trailing whitespace.
put/regression/midi/out-test-baseline input/regression/midi/out-test
warning: 1 line adds whitespace errors.
People, a patchy run is quite more expensive than "make test", and my
computer is quite less powerful than yours. Try not to waste my time
all that unnecessarily, do some basic checks yourself.
tail from the log:
LILYPOND_VERSION=2.15.34 /usr/bin/python /tmp/lilypond-autobuild/scripts/lilypond-book.py -I /tmp/lilypond-autobuild/input/regression/svg/ -I ./out-test -I /tmp/lilypond-autobuild/input -I /tmp/lilypond-autobuild/Documentation -I /tmp/lilypond-autobuild/Documentation/snippets -I /tmp/lilypond-autobuild/input/regression/ -I /tmp/lilypond-autobuild/Documentation/included/ -I /tmp/lilypond-autobuild/build/mf/out/ -I /tmp/lilypond-autobuild/build/mf/out/ -I /tmp/lilypond-autobuild/Documentation/pictures -I /tmp/lilypond-autobuild/build/Documentation/pictures/./out-test --process=/tmp/lilypond-autobuild/build/out/bin/lilypond -I /tmp/lilypond-autobuild/input/regression/svg/ -I ./out-test -I /tmp/lilypond-autobuild/input -I /tmp/lilypond-autobuild/Documentation -I /tmp/lilypond-autobuild/Documentation/snippets -I /tmp/lilypond-autobuild/input/regression/ -I /tmp/lilypond-autobuild/Documentation/included/ -I /tmp/lilypond-autobuild/build/mf/out/ -I /tmp/lilypond-autobuild/build/mf/out/ -I /tmp/lilypond-autobuild/Documentation/pictures -I /tmp/lilypond-autobuild/build/Documentation/pictures/./out-test -dbackend=eps --formats=ps,png,pdf -dinclude-eps-fonts -dgs-load-fonts --header=doctitle --header=doctitlecs --header=doctitlede --header=doctitlees --header=doctitlefr --header=doctitlehu --header=doctitleit --header=doctitleja --header=doctitlenl --header=doctitlezh --header=texidoc --header=texidoccs --header=texidocde --header=texidoces --header=texidocfr --header=texidochu --header=texidocit --header=texidocja --header=texidocnl --header=texidoczh -dcheck-internal-types -ddump-signatures -danti-alias-factor=2 --output=./out-test --format=texi --loglevel=WARN --skip-png-check --use-source-file-names --lily-output-dir /tmp/lilypond-autobuild/build/out/lybook-db --redirect-lilypond-output out-test/collated-files.tely
langdefs.py: warning: lilypond-doc gettext domain not found.
lilypond-book.py: error: file not found: out-test/collated-files.tely
lilypond-book.py (GNU LilyPond) 2.15.34
make[1]: *** [out-test/collated-files.texi] Error 1
Leaving directory `/tmp/lilypond-autobuild/build/input/regression/svg'
Originally posted by: julien.r...@gmail.com
I set Patch=needs_work as soon as I noticed the problem... looks like it wasn't early enough.
The interesting bit comes a bit earlier in the log:
No files specified. Doing nothing
This comes from lys-to-tely script, and indeed there are no files specified because there are no regression tests added yet in the input/regresssion/svg directory.
Now, how could I have missed that? I have a dummy .ly file in my tree under input/regression/svg, so everything progresses perfectly. I didn't add this .ly file to the patch because it is a rather silly little file that doesn't test anything specific. When I remove the file, make check still passes, because the file out-test/collated-files.tely is present from the previous run. So I didn't expect that an empty regtest dir would cause problem. The only way for me to have noticed the problem would be to start from a new build dir, but that's what I expect patchy to do. So I upload the patch and overnight I ran patchy.
(PS. the trailing whitespace warning comes from git patch --reverse)
Originally posted by: julien.r...@gmail.com
I've uploaded another patch, but I'm not setting Patch=new just yet while I do the testing with patchy.
Originally posted by: julien.r...@gmail.com
What exactly is needed from svg regtests? Do we want only textual comparison of the generated svg files or also png output comparison?
Originally posted by: m...@mikesolomon.org
I vote for only textual comparison.
Originally posted by: julien.r...@gmail.com
The problem I have is that one small change in coordinates leads to a full-line diff. Changes to ID could easily get lost. So I need to either filter or weight the different types of changes in the file.
Originally posted by: m...@mikesolomon.org
I was thinking that we could just use xml.dom.minidom to pare the svg files and then do the regtest based on the parsed content (for example, verifying that there are X many ids containing the word "foo", etc). Would that be swingable?
Originally posted by: julien.r...@gmail.com
That would be better. Is the xml module part of standard python distributions by default, or would it be an added dependencies to integrate into lilydev and gub?
Originally posted by: m...@mikesolomon.org
That's a good question...it's part of the Mac OS X python distribution & it's in my lilydev, but it'd be worth it to check if gub-built python has it.
Originally posted by: julien.r...@gmail.com
I have no more time to work on this.
Labels: -Patch-needs_work Patch-abandoned
Owner: ---
Status: Accepted