Menu
▾
▴
#2203 Patch: separate narrowed accidentals
Accepted
nobody
None
needs_work
Enhancement
2015-10-25
2012-01-07
Anonymous
No
Originally created by: *anonymous
Originally created by: janek.li...@gmail.com
Originally owned by: janek.li...@gmail.com
separate narrowed accidentals
leaving arrows alone
font: narrowed variants of accidentals
As discussed in issue 2142, narrower versions
of accidentals would be useful for typesetting
very tight music. This patches adds such narrow
accidentals to the font. Samples showing them
are attached to tracker issue.
Originally posted by: janek.li...@gmail.com
ignore first 3 sentences, it was a mistake.
In the attached example of sonate op. 35 narrow accidentals replace all regular accidentals; of course when appropriate C++ code will be written only some accidentals will be narrow, and they'll also have smaller padding.
Status: Started
Originally posted by: lilypond...@gmail.com
Patchy the autobot says: LGTM.
Labels: Patch-review
Originally posted by: lemzw...@googlemail.com
Thanks for working on this. Some comments.
(1) For my taste, `natural.narrow' is squeezed too much: Its width is no longer in balance with the width of `sharp.narrow'.
(2) If normal and squeezed accidentals get mixed, accidentals in the key must not be squeezed, I think. This is probably another reason for avoiding (1).
We should also explore how to give accidentals better horizontal and vertical skylines.
Originally posted by: janek.li...@gmail.com
Of course accidentals in key signature should be normal-sized. That file is only a artificial example of narrow accidentals in somewhat "real" situation.
As for natural, the ratio (narrow natural width)/(narrow sharp width) is actually bigger than in normalsize natural and sharp.
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Owner: janek.li...@gmail.com
Originally posted by: lemzw...@googlemail.com
Well, I feel that the squeezed natural is simply too narrow... Can you make it a bit wider, please?
Originally posted by: pkx1...@gmail.com
Janek,
Looking at the examples, did you just literally reduce the 'width' and nothing else, of the accidental?
I'm in agreement with Werner here, they look too narrow and I am wondering if this is because the height hasn't changed. Perhaps it is subtle but the proportions look odd and from a distance the naturals and sharps are starting too look similar. Also can you make some 'c? cis?' type examples too (showing the parenthesis) to make sure that this all still spaces correctly?
Originally posted by: janek.li...@gmail.com
separate narrowed accidentals
leaving arrows alone
font: narrowed variants of accidentals
As discussed in issue 2142, narrower versions
of accidentals would be useful for typesetting
very tight music. This patches adds such narrow
accidentals to the font. Samples showing them
are attached to tracker issue.
http://codereview.appspot.com/5527049
Labels: Patch-new
Originally posted by: janek.li...@gmail.com
James,
"Looking at the examples, did you just literally reduce the 'width' and nothing else, of the accidental?"
Yes. This resulted in natural being narrower, but all it's lines have exactly the same thickness (so it isn't simply scaled down in X axis).
According to your suggestions i've made narrow natural a bit wider. I also attach a more "reasonable" example of narrow accidentals (their narrowness is really used in this example).
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: lemzw...@googlemail.com
LGTM, thanks.
Originally posted by: dak@gnu.org
Scaling the shape down uniformly is not optimal for good optical scaling. You would also likely reduce the overall line thickness slightly, and shrink the middle "cross" somewhat less than the arms so that it does not fill with ink (the arm corners have theoretically the same problem, but it tends to be less serious than the middle).
It is customary to then create a number of large-scale proofs with slight graduation in parameters, possibly with surrounding tight note heads (so that one can judge the best compromise also actually saving space), and stare at them from a distance until your eyes fall out.
Originally posted by: lemzw...@googlemail.com
David,
is your remark of general nature? Otherwise, could be more specific, please? For me, Janek's first try is fine, and later on he might fiddle with the details if necessary. I trust him that he is his own strongest critics w.r.t. shapes, based on what he has already contributed :-)
Originally posted by: pkx1...@gmail.com
Why are we including 'Accidentals' in with 'KeySignature' - yes we use sharps and flats in both but they are distinct musical 'things' and the problem that narrow accidentals is trying to solve doesn't in my opinion have anything to do with KeySignature.
Originally posted by: n.putt...@gmail.com
Janek, you must add accurate boxes for the new accidentals before pushing this, otherwise the natural and flat will get poor positioning in sixths.
\version "2.15.25"
\relative c'' {
<ces as'>2^"default"
<c a'>
\override Accidental #'glyph-name-alist =
#'((0 . "accidentals.natural.narrow")
(-1/2 . "accidentals.flat.narrow")
(1/2 . "accidentals.sharp.narrow"))
<ces as'>2^"narrow"
<c a'>
}
Originally posted by: ColinPKC...@gmail.com
Per Neil's comments
Labels: -Patch-countdown Patch-needs_work
Originally posted by: janek.li...@gmail.com
I should've written this a lot earlier:
many thanks for the comments. I'll address them after i do some more work on Patchy and automation.
Diff:
This patch appears to contain a substantial amount of the work required to provide this enhancement, so I'm leaving it as needs_work rather than abandoned, but as the Issue has no owner and there has been no action for well over three years I'm reverting the Status to Accepted rather than Started.