Menu

#2165 Patch: Modifies broken hairpin height

Verified
nobody
Enhancement
2015-09-19
2012-01-01
Anonymous
No

Originally created by: *anonymous

Originally created by: mts...@gmail.com
Originally owned by: mts...@gmail.com

Modifies broken hairpin height

http://codereview.appspot.com/5502089

Discussion

  • Google Importer

    Google Importer - 2012-01-01

    Originally posted by: m...@mikesolomon.org

    This is a follow-up to comment 38 of issue 2057.

     

    Related

    Issues: #2057

  • Google Importer

    Google Importer - 2012-01-01

    Originally posted by: lilypond...@gmail.com

    Patchy the autobot says: LGTM.

    Labels: Patch-review

     
  • Google Importer

    Google Importer - 2012-01-02

    Originally posted by: k-ohara5...@oco.net

    This one is purely aesthetics.  It reduces the opening of hairpins when they are broken. From 1/2 to 1/3 of full height on the soft end, and from 1.0 to 2/3 on the loud end.  Attached are (inadequate, but use your imagination) before- and after examples.

     
  • Google Importer

    Google Importer - 2012-01-02

    Originally posted by: janek.li...@gmail.com

    I like these results!  Thanks!

     
  • Google Importer

    Google Importer - 2012-01-03

    Originally posted by: prze...@gmail.com

    Thanks for making it.

    There is still the problem of padding (i.e. lack of it), mentioned in the same comment 38 of issue 2057 (suggesting sane default, IMHO). If it is solved in issue 2130, then sorry for making the buzz again -- I don't see 2.15.24 released yet, so cannot test (w/o building it myself) and tell for sure.

     

    Related

    Issues: #2057
    Issues: #2130

  • Google Importer

    Google Importer - 2012-01-03

    Originally posted by: ColinPKC...@gmail.com

    (No comment was entered for this change.)

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2012-01-05

    Originally posted by: ColinPKC...@gmail.com

    Counted down to 20120105, please push.

    Labels: -Patch-countdown Patch-push

     
  • Google Importer

    Google Importer - 2012-01-06

    Originally posted by: mts...@gmail.com

    Pushed to staging as [r87a8ec69e1ef15aa6e18c11ec7d674ce46e0b5b7].

    Status: Fixed

     
  • Google Importer

    Google Importer - 2012-01-06

    Originally posted by: k-ohara5...@oco.net

    un-pushed.  push again.

    Status: Accepted

     
  • Google Importer

    Google Importer - 2012-01-20

    Originally posted by: pkx1...@gmail.com

    (No comment was entered for this change.)

    Owner: mts...@gmail.com
    Status: Started

     
  • Google Importer

    Google Importer - 2012-02-11

    Originally posted by: ColinPKC...@gmail.com

    This looks as though it got repushed as [ree12a32549ed3802251669b9ad511141fda7b9a0]
    Mike, would you confirm and mark this fixed and the REitveld item closede, please?

     
  • Google Importer

    Google Importer - 2012-02-13

    Originally posted by: mts...@gmail.com

    (No comment was entered for this change.)

    Labels: Fixed_2_15_30
    Status: Fixed

     
  • Google Importer

    Google Importer - 2012-02-13

    Originally posted by: colingh...@gmail.com

    Verified commit present in repo

    Status: Verified

     
  • Google Importer

    Google Importer - 2012-02-13

    Originally posted by: colingh...@gmail.com

    (No comment was entered for this change.)

    Status: Fixed

     
  • Google Importer

    Google Importer - 2012-02-19

    Originally posted by: colingh...@gmail.com

    Verified that this patch was committed to the repo under the committish in Comment 11 above.

    Status: Verified

     
  • Anonymous

    Anonymous - 2015-09-19
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2015-09-19

    .

     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.