Menu

#2153 piano pedal bracket should stop at requested moment

Verified
nobody
Defect
2012-01-13
2011-12-29
Anonymous
No

Originally created by: *anonymous

Originally created by: k-ohara5...@oco.net
Originally owned by: k-ohara5...@oco.net

Piano pedal spanners listen for notes/rests on their Staff, so they can stop at the last note/rest within their span.

I think we always want the spanner to end at the moment we request, like they do if they are not in their own Dynamics context.

\version "2.14"
<<
  \new Staff \repeat unfold 12 b'4
  \new Staff \with {pedalSustainStyle = #'mixed } <<
    \new Voice {b1 b1 b}
    \new Voice {s1\sustainOn s2. s4\sustainOn\sustainOff s1 } >>
  \new Dynamics \with {pedalSustainStyle = #'mixed } {
    s1\sustainOn s2. s4\sustainOn\sustainOff s1 } >>

% Workaround, to have pedals set in the Staff so they are printed close
% to the staff, is to use invisible zero-extent rests instead of spacers:
% \new Voice = "pedal" \with {
%    \override Rest #'stencil = ##f
%    \override Rest #'Y-extent = #'(+inf.0 . -inf.0) }

<http://codereview.appspot.com/5500093>

1 Attachments

Discussion

  • Google Importer

    Google Importer - 2011-12-30

    Originally posted by: PhilEHol...@googlemail.com

    Keith - is this related to Issue 1128?

     
  • Google Importer

    Google Importer - 2011-12-30

    Originally posted by: k-ohara5...@oco.net

    Issue 1128 affects only the text-style pedal indications, the early-finishing shown above affects only brackets.  (I thought about issue 1128 too, but did not see a good approach.)

    Summary: piano pedal bracket should stop at requested moment

     
  • Google Importer

    Google Importer - 2011-12-31

    Originally posted by: lilypond...@gmail.com

    Patchy the autobot says: LGTM.

    Labels: Patch-review

     
  • Google Importer

    Google Importer - 2012-01-01

    Originally posted by: ColinPKC...@gmail.com

    (No comment was entered for this change.)

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2012-01-03

    Originally posted by: ColinPKC...@gmail.com

    Counted down to 20120103, please push

    Labels: -Patch-countdown Patch-push

     
  • Google Importer

    Google Importer - 2012-01-04

    Originally posted by: k-ohara5...@oco.net

    commit e5a7fc9 to staging

    Labels: -Patch-push fixed_2_15_24
    Status: Fixed

     
  • Google Importer

    Google Importer - 2012-01-13

    Originally posted by: ma...@gregoriana.sk

    (No comment was entered for this change.)

    Status: Verified

     
MongoDB Logo MongoDB