Menu
▾
▴
#2130 Hairpin hits barline at line break
Originally created by: *anonymous
Originally created by: gra...@percival-music.ca
Originally owned by: k-ohara5...@oco.net
Continuation from issue 2057
sorry, the google python API only gives me the first 25 comments, I couldn't find anything in their code to explain this after 30 minutes, and I'm too sick to look further. As a result, at the moment Patchy can't track anything longer than that. Patches appreciated.
- Graham
Keith said:
I've put this back to Started. The code base at the moment treats hairpins ending at the end of the line the same as those that continue, so all hairpins get the smaller padding at the end of the line, and none at all if there is no span bar.
Mike and I agreed to integrate his code into the old system. Then ending hairpins get the simple 'bound-padding while those continuing across the line break get 'broken-bound-padding, which by default uses Mike's new code, and people can override either if needed. After-patch output attached.
<http://codereview.appspot.com/5479071/>
Originally posted by: gra...@percival-music.ca
Issue 2057 has been merged into this issue.
Related
Issues:
#2057Originally posted by: gra...@percival-music.ca
http://codereview.appspot.com/5479071
Originally posted by: lilypond...@gmail.com
Patchy the autobot says: LGTM.
Labels: Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown Type-Ugly
Originally posted by: ColinPKC...@gmail.com
Counted down to the Winter Solstice 20111222, please push
Labels: -Patch-countdown Patch-push
Originally posted by: k-ohara5...@oco.net
Starting in version 2.15.24, the original example from issue 2057 should behave as desired.
Labels: -Type-Ugly Fixed_2_15_24
Status: Fixed
Related
Issues:
#2057Originally posted by: ColinPKC...@gmail.com
Using 2.15.24, the hairpins in the original example seem to be the same, and none hit barlines.
Status: Verified
Originally posted by: prze...@gmail.com
Sorry for bothering you again, but original example lacked broken hairpins (that I mentioned in one of my comments in issue 2057) and they're still touching the span bar in 2.15.26. Moreover, changing broken-bound-padding has no effect.
Related
Issues:
#2057Originally posted by: pkx1...@gmail.com
Opened https://code.google.com/p/lilypond/issues/detail?id=2259
for the new report. Leave this one as 'fixed'.
Related
Issues:
#2259Originally posted by: k-ohara5...@oco.net
Compiling the original example from issue 2057, with versions 2.15.24 and .26, I see hairpins ending clear of bar lines.
Related
Issues:
#2057.