Menu
▾
▴
1 Attachments
#2065 Scripts in cross-staff constructions can collide with span bars
Originally created by: *anonymous
Originally created by: k-ohara5...@oco.net
This is a minor issue known from patch reviews, that I just don't want to forget.
\new GrandStaff <<
\new Staff = "a" {g1 R s }
\new Staff = "b" {
\clef bass [r1] [r2]. g8( b |
d'\prall\espressivo \change Staff="a" b') g'2.} >>
The espressivo has always collided with the stem; now it collides with the span bar as well.
[r4f49b000d6e257724e311b406e2346b8388c1f0e] is the first bad commit :
Improves horizontal spacing of vertical axis groups that span bars traverse. Fixes issue 1846.
Originally posted by: mts...@gmail.com
The problem is that the Script is marked as cross-staff and thus not taken into account in the Separation_item::boxes. This is going to be difficult to fix, as cross-staffitude is hard wired all over LilyPond and if you mess with it one place, it comes back to bite you in 5.
I'll mull it over...
Originally posted by: mts...@gmail.com
Interesting - if you add \override Score . Script #'cross-staff = ##f, it doesn't fix the problem. So the cross-staffitude is factoring in in a much more subtle way.
Originally posted by: mts...@gmail.com
Prevents SpanBar Script collisions.
http://codereview.appspot.com/5478064
Labels: Patch-new
Originally posted by: k-ohara5...@oco.net
> The problem is ... not taken into account in the Separation_item::boxes.
Just to correct the record, cross-staff items like the espressivo in the example /do/ get boxes for horizontal spacing. That's how they avoid bar lines within the staff, formerly avoided the old SpanBars, and /usually/ get spaced away from the new SpanBarStubs.
The new SpanBarStubs sometimes get confused about how high they need to be.
Originally posted by: mts...@gmail.com
Slight re-correction: there are actually no SpanBarStubs created in the example above. Everything is done through extra-spacing-height, which for some reason doesn't like cross-staff Stems.
Actually, the pure-from-neighbor-interface could be used to prevent stem-on-articulation collisions. You just need to create a grob MusicalSpacingStub, let it use this interface, and it'll block this sorta collision the same way that SpanBarStubs block Lyric vs SpanBar collisions.
Cheers,
MS
Originally posted by: lilypond...@gmail.com
Patchy the autobot says: LGTM.
Labels: Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: ColinPKC...@gmail.com
Counted down to 20111215
Labels: -Patch-countdown Patch-push
Originally posted by: mts...@gmail.com
Pushed to staging as [r5543eb5b0378bc726684a686b799e4ff4dc5f4cc].
Status: Fixed
Originally posted by: colingh...@gmail.com
Verified that commit is present in staging
Status: Verified
.