Menu
▾
▴
#2060 Patch: Hairpin missing padding at line break
Originally created by: *anonymous
Originally created by: k-ohara5...@oco.net
Originally owned by: k-ohara5...@oco.net
%% Hairpin at a line break reaches the end of the bar,
%% whereas for a normal bar (i.e. not at a line break)
%% it stops just short.
\version "2.15.18"
\relative c' {
c1\p\< | c\f\> | \break
c1\p\< | c\f\> | c1\p\< | \break
c1\f
}
Originally posted by: k-ohara5...@oco.net
An example to explain the difference between this patch, and the one for issue 2057.
m = {
\clef alto g2\f\> g\p\< |\break
g2\f\> g | g g\p\< |\break
b2 b\f\> | g2\p g \bar"|."}
\new GrandStaff <<
\new Staff \m
\new Staff \m >>
This patch merely spaces hairpins from the end-of-line as if it were any other bar line (no splitting of continued hairpins, detection of span-bars, or anything fancy).
Originally posted by: pkx1...@gmail.com
Passes make and make check
James
Labels: -Patch-new Patch-review
Owner: mts...@gmail.com
Originally posted by: k-ohara5...@oco.net
The patch actually changes ‘dynamics-broken-hairpin.ly’ as expected, but it doesn't move enough pixels for the automated tester to report it.
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: k-ohara5...@oco.net
Mike pointed out that the root cause of the problem was a poorly-named function,
so I went one level deeper to make the function do what its name implies.
Competely different patch at <http://codereview.appspot.com/5373048/>
with the same effect in issues 2060 and 2057.
Labels: -Patch-countdown patch-new
Originally posted by: pkx1...@gmail.com
Passes Make and I get no reg test diffs.
James
Labels: -patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Owner: k-ohara5...@oco.net
Originally posted by: ColinPKC...@gmail.com
Counted down to 20111204
Labels: -Patch-countdown Patch-push
Originally posted by: k-ohara5...@oco.net
Version 2.15.21 and beyond should typeset the hairpins in the initial example in a uniform way.
Labels: -Patch-push fixed2_15_21
Status: Fixed
Originally posted by: k-ohara5...@oco.net
The fix that got pushed for issue 2057 changed the intended output from what was intended, but the underlying code-cleanup is in place. Issue 2130 tracks that the output will come out right in the end, so I'll mark this one invalid.
Status: Invalid