Menu
▾
▴
1 Attachments
#2057 Hairpin hits barline at line break
Verified
nobody
None
Ugly
2012-01-08
2011-11-27
Anonymous
No
Originally created by: *anonymous
Originally created by: PhilEHol...@googlemail.com
Originally owned by: k-ohara5...@oco.net
%% Hairpin at a line break touches the barline, whereas for a normal bar
%% (i.e. not at a line break) it does not.
\version "2.15.18"
music = \relative c' {
c1\p\< | c\f\> | \break
c1\p\< | c\f\> | c1\p\< | \break
c1\f
}
\score {
<<
\new StaffGroup <<
\new Staff {
\music
}
\new Staff {
\music
}
>>
>>
}
Originally posted by: mts...@gmail.com
Adds padding between Hairpins and SpanBars.
http://codereview.appspot.com/5438060
Labels: Patch-new
Originally posted by: pkx1...@gmail.com
Passes Make and make check
James
Labels: -Patch-new Patch-review
Owner: mts...@gmail.com
Status: Started
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: mts...@gmail.com
Adds padding between Hairpins and SpanBars.
http://codereview.appspot.com/5438060
Labels: Patch-new
Originally posted by: mts...@gmail.com
Adds padding between Hairpins and SpanBars.
http://codereview.appspot.com/5438060
Originally posted by: pkx1...@gmail.com
Passes Make and make check
james
Labels: -Patch-new Patch-review
Originally posted by: k-ohara5...@oco.net
I received a question about the desired behavior.
Currently a hairpin below the staff group ends directly below the parallel hairpin above.
At the end of a line, should hairpin ends be vertically aligned in a similar way, or we shorten /only/ those that would actually hit a span bar ?
Originally posted by: prze...@gmail.com
I think that for system's integrity and good looking result all hairpins should have equal length if defined in the same way, thus shortening should happen all the time, even if there is no span bar that would be hit by it.
(BTW I am the bug reporter via ML)
Originally posted by: x.sche...@gmail.com
+1, hairpin ends vertically aligned in a similar way.
(i.e. I agree with the comment just above, #c8)
Originally posted by: Carl.D.S...@gmail.com
This second request seems to me to be a new issue, i.e. Hairpins in parallel with those shortened to avoid collisions with span bars should also be shortened.
But maybe it should just be part of this one.
Thanks,
Carl
Originally posted by: prze...@gmail.com
It's all about obtaining sane behavior and IMO hairpin length should be the same whether there is span bar or just bar. Is there any good reason to make hairpin length dependent on bar's span? My initial report contained span bar, but only because that's how I noticed it, not because I wished to fixing it partly, i.e. only in case of span bar.
As for splitting it into more issues, do as you think will be the best, but I intuit (maybe wrongly?) it'd better to go at it at once.
Originally posted by: mts...@gmail.com
Adds padding between Hairpins and SpanBars.
http://codereview.appspot.com/5438060
Labels: Patch-new
Originally posted by: mts...@gmail.com
Attached is the most recent version of the new regtest in light of the conversation about everything lining up.
Originally posted by: mts...@gmail.com
Sorry - previous posted file was incorrect.
Originally posted by: k-ohara5...@oco.net
I added issue 2060, with linked patch, to make the existing "bound-padding" be applied to hairpins consistently.
Originally posted by: pkx1...@gmail.com
Passes make and make check
James
Labels: -Patch-new Patch-review
Originally posted by: mts...@gmail.com
Adds padding between Hairpins and SpanBars.
http://codereview.appspot.com/5438060
Labels: Patch-new
Originally posted by: pkx1...@gmail.com
Passes Make - reg tests attached
James
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: bealings...@googlemail.com
I don't think the regtests look good. The new hairpins are hitting dynamics markings, and I think the old ones stopping short of the bar lines looked better.
Originally posted by: prze...@gmail.com
It started about too long hairpin in last measure in the line. Why the padding is removed now for non-last measures? Does it require splitting into third issue? I don't get it.
Hairpins starting or/and ending at measure boundaries should have padding next to the boundaries independently of dynamics placement (up/down), bar's span and measure placement (last/non-last in line).
Or the new version is on the left in attached screenshot?
Originally posted by: mts...@gmail.com
Adds padding between Hairpins and SpanBars.
http://codereview.appspot.com/5438060
Labels: Patch-new
Originally posted by: mts...@gmail.com
What does Gould et. al. have to say about hairpins w/ respect to bar lines, line breaks & span bars?
Originally posted by: k-ohara5...@oco.net
> It started about too long hairpin in last measure in the line.
The too-long hairpin in the last measure, longer that those in other measures, was due to a minor coding error, and that is very simple to repair. I created issue 2060 to record and fix that bug alone.
Mike interpreted the report to be a request for different spacing of hairpins that touch the span bar at the end of the line, including the case where the (de)crescendo continues across the line break. That new code, at the link in comments above, is still being debugged.
I am happy that people are commenting about the effects of the changes, compared to what they want. That makes it more likely to get a bug-fix or fixes that do what people really want.
Originally posted by: k-ohara5...@oco.net
Mike's patch now incorporates my fix to shorten hairpins at end-of-line (issue 2060) and goes further:
1) if a Hairpin continues across the line-break shorten it to clear any span-bar
2) if a (partial) Hairpin is free from span-bars, and no simultaneously-ending (partial) Hairpin needs to avoid a span-bar, then print it a little longer.
I don't like it, but maybe the customized lengths gives the output a more human touch? Just give us an option to turn your new features off, Mike.