Originally created by: *anonymous
Originally created by: mts...@gmail.com Originally owned by: mts...@gmail.com
Fixes NoteColumn vs SpanBar collisions.
http://codereview.appspot.com/5323062
Issues: #2272
Originally posted by: k-ohara5...@oco.net
% I picked a bad example, where the flats catch the lower bar line % A clearer example is \new PianoStaff << \new Staff { c'1 | eeses4 f g a | c'1 } \new Staff { c'1 | c'''1 eeses4 f g a | } >>
Originally posted by: mts...@gmail.com
Originally posted by: pkx1...@gmail.com
(No comment was entered for this change.)
Owner: mts...@gmail.com
Passes Make but lots of reg test diffs here:
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-td4962666.html
James
Labels: -Patch-new Patch-review Status: Started
Originally posted by: ColinPKC...@gmail.com
Labels: -Patch-review Patch-countdown
Labels: Patch-new
Passes Make but lots of reg test diffs
Labels: -Patch-new Patch-review
Passes Make and reg test diffs
Passes make but lots of reg test diffs as usual
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-7-Nov-2011-td4962666.html
Adds some info about pure properties to the CG.
http://codereview.appspot.com/5364048
Passes Make, all reg test diffs here:
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-8-Nov-2011-td4962666.html
james
passes make and reg test diffs are all here:
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-9-Nov-2011-td4962666.html
Labels: -Patch-review Patch-new
passes make and reg tests all posted here:
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-10-Nov-2011-td4962666.html
Per Mike's comments on Rietveld, still being revised
Labels: -Patch-review Patch-needs_work
Doesn't pass make
--snip--
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/lily-sort.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-functions.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-translation.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-music.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-type-predicates.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-identifiers.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-context-mods.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-backend.scm fatal error: define-grob-properties.scm: cannot find interface for property: has-span-bar make[1]: *** [out/internals.texi] Error 1 make[1]: Leaving directory `/home/jlowe/lilypond-git/build/Documentation' make: *** [all] Error 2 jlowe@jlowe-lilybuntu2:~/lilypond-git/build$
--snip-
Labels: -Patch-new Patch-needs_work
Originally posted by: k-ohara5...@oco.net
% I picked a bad example, where the flats catch the lower bar line
% A clearer example is
\new PianoStaff <<
\new Staff {
c'1 |
eeses4
f g a | c'1
}
\new Staff {
c'1 | c'''1
eeses4
f g a |
} >>
Originally posted by: mts...@gmail.com
Fixes NoteColumn vs SpanBar collisions.
http://codereview.appspot.com/5323062
Originally posted by: pkx1...@gmail.com
(No comment was entered for this change.)
Owner: mts...@gmail.com
Originally posted by: mts...@gmail.com
Fixes NoteColumn vs SpanBar collisions.
http://codereview.appspot.com/5323062
Originally posted by: mts...@gmail.com
Fixes NoteColumn vs SpanBar collisions.
http://codereview.appspot.com/5323062
Originally posted by: pkx1...@gmail.com
Passes Make but lots of reg test diffs here:
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-td4962666.html
James
Labels: -Patch-new Patch-review
Status: Started
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: mts...@gmail.com
Fixes NoteColumn vs SpanBar collisions.
http://codereview.appspot.com/5323062
Labels: Patch-new
Originally posted by: pkx1...@gmail.com
Passes Make but lots of reg test diffs
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-td4962666.html
James
Labels: -Patch-new Patch-review
Originally posted by: mts...@gmail.com
Fixes NoteColumn vs SpanBar collisions.
http://codereview.appspot.com/5323062
Labels: Patch-new
Originally posted by: pkx1...@gmail.com
Passes Make and reg test diffs
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-td4962666.html
James
Labels: -Patch-new Patch-review
Originally posted by: mts...@gmail.com
Fixes NoteColumn vs SpanBar collisions.
http://codereview.appspot.com/5323062
Labels: Patch-new
Originally posted by: mts...@gmail.com
Fixes NoteColumn vs SpanBar collisions.
http://codereview.appspot.com/5323062
Originally posted by: pkx1...@gmail.com
Passes make but lots of reg test diffs as usual
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-7-Nov-2011-td4962666.html
James
Labels: -Patch-new Patch-review
Originally posted by: mts...@gmail.com
Adds some info about pure properties to the CG.
http://codereview.appspot.com/5364048
Labels: Patch-new
Originally posted by: mts...@gmail.com
Fixes NoteColumn vs SpanBar collisions.
http://codereview.appspot.com/5323062
Originally posted by: pkx1...@gmail.com
Passes Make, all reg test diffs here:
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-8-Nov-2011-td4962666.html
james
Labels: -Patch-new Patch-review
Originally posted by: mts...@gmail.com
Fixes NoteColumn vs SpanBar collisions.
http://codereview.appspot.com/5323062
Labels: Patch-new
Originally posted by: pkx1...@gmail.com
passes make and reg test diffs are all here:
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-9-Nov-2011-td4962666.html
James
Labels: -Patch-new Patch-review
Originally posted by: mts...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-new
Originally posted by: pkx1...@gmail.com
passes make and reg tests all posted here:
http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-10-Nov-2011-td4962666.html
James
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
Per Mike's comments on Rietveld, still being revised
Labels: -Patch-review Patch-needs_work
Originally posted by: mts...@gmail.com
Fixes NoteColumn vs SpanBar collisions.
http://codereview.appspot.com/5323062
Labels: Patch-new
Originally posted by: mts...@gmail.com
Fixes NoteColumn vs SpanBar collisions.
http://codereview.appspot.com/5323062
Originally posted by: pkx1...@gmail.com
Doesn't pass make
--snip--
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/lily-sort.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-functions.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-translation.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-music.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-type-predicates.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-identifiers.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-context-mods.scm]
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-backend.scm
fatal error: define-grob-properties.scm: cannot find interface for property: has-span-bar
make[1]: *** [out/internals.texi] Error 1
make[1]: Leaving directory `/home/jlowe/lilypond-git/build/Documentation'
make: *** [all] Error 2
jlowe@jlowe-lilybuntu2:~/lilypond-git/build$
--snip-
James
Labels: -Patch-new Patch-needs_work