Menu
▾
▴
#1905 Add note to CG 9.3 'Compiling reg tests' to add --disable-optimising when using autogen.sh or configure
Originally created by: *anonymous
Originally created by: pkx1...@gmail.com
Piers Titus van der Torren pierstitus@gmail.com via gnu.org to lilypond-devel
Hey all,
Since --disable-optimising enables assertion, making regtests should be done with that option, as Neil Puttock mentioned http://codereview.appspot.com/4974075/#msg12
I think it's useful to add a note about this in the documentation in chapter 9.3 Compiling regression tests.
It seems I'm not the only one who didn't know.
Piers
Originally posted by: mts...@gmail.com
I knew and I still messed it up because I forgot to optimize my binary for regtest checks.
The patch below should guarantee that this type of slip-up doesn't happen anymore:
http://codereview.appspot.com/5067042
Cheers,
MS
Originally posted by: n.putt...@gmail.com
Won't your patch break GUB builds?
Originally posted by: percival.music.ca@gmail.com
probably. Also, Mike uploaded another patch to that codereview issue, so it's all confused.
Labels: Patch-needs_work
Originally posted by: pkx1...@gmail.com
OK so what I have done is a doc patch here:
http://codereview.appspot.com/5081048
I'll open a new tracker for Mike's suggestion as I think that is a much bigger discussion.
James
Labels: -Patch-needs_work Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: percival.music.ca@gmail.com
I don't like the ./autogen.sh stuff.
Labels: -Patch-countdown Patch-needs_work
Originally posted by: pkx1...@gmail.com
OK i've taken it out.
http://codereview.appspot.com/5081048
Labels: -Patch-needs_work Patch-review
Originally posted by: pkx1...@gmail.com
Pushed as commit [r0290695173284ccf68b08c0e92734d76df7120fd]
Graham ok'd this.
James
Labels: -Patch-review
Status: Fixed
Originally posted by: brownian.box@gmail.com
(No comment was entered for this change.)
Labels: fixed_2_15_13
Status: Verified