Menu
▾
▴
1 Attachments
#1856 lots of extra space at beginning of bar
Originally created by: *anonymous
Originally created by: percival.music.ca@gmail.com
Originally owned by: k-ohara5...@oco.net
2.15.9 sometimes has a (relatively) huge amount of space before the first note in a score. See
input/regression/dynamics-alignment-breaker-linebreak.ly
Originally posted by: percival.music.ca@gmail.com
similar weirdness in key-clefs.ly
Originally posted by: percival.music.ca@gmail.com
also hara-kiri-alive-with.ly
Originally posted by: percival.music.ca@gmail.com
spanner-break-beyond-parent.ly
hairpin-barline-break.ly
instrument-name-hara-kiri.ly
dynamics-broken-hairpin.ly
page-break-turn-toplevel.ly
paper-nested-override.ly
Originally posted by: k-ohara5...@oco.net
This is from a last-minute addition to my fix to issue 1785.
The affected tests are those that have very few notes stretched a line.
The space after key- and time- signatures was formerly "fixed-space".
There was code that tried to make "fixed-space" be relatively incompressible, but it was not working as intended since about version 2.10.24-ish. "Fixed-space" was unstretchable, but it would compress easily. That was issue 1785.
While reviewing the fix to issue 1785 Janek noted that strictly incompressible space after key signatures looked bad on tight scores.
There is a choice "semi-fixed-space" in the framework for space after prefatory matter. Such space stretches as well as it compresses. Checking code comments and textbooks and mailing archives, I found no reason for LilyPond to have inflexible space after time- and key-signatures, so I changed it to "semi-fixed-space"
Do we want the space after key- and time-signatures to be non-stretchable ?
If so, just revert cc88cd3680 .
If nobody has any reason to want the space to be inflexible, I'll mark this invalid after a week or so.
Originally posted by: tdanielsmusic
In my opinion the large space after key signature and time signature on sparsely populated lines is wrong. The notes are displaced too far from their position in the bar in comparison with lines following which have no prefatory matter. So I agree this is a critical regression and my vote is for reverting cc88cd3680.
Originally posted by: k-ohara5...@oco.net
I now agree now that we want fixed space after key signatures, so that the first notes line up on successive lines. Sorry I didn't notice that earlier.
Any reason to prevent the space after time signatures from stretching, through?
The change would be in define-grobs.scm, under KeySignature and maybe TimeSignature and KeyCancellation, to restore "semi-fixed-space" back to "fixed-space"
Originally posted by: tdanielsmusic
Yes, the space after both key _and_ time signatures looked wrong, for the reasons I gave in comment 5.
Originally posted by: k-ohara5...@oco.net
http://codereview.appspot.com/4964059
Labels: Patch-new
Owner: k-ohara5...@oco.net
Status: Started
Originally posted by: pkx1...@gmail.com
Passes make but I get a lot of reg test differences (probably expected) I have attached those that show the most significant shifts - approx 30.
James
Labels: -Patch-new Patch-review
Originally posted by: percival.music.ca@gmail.com
Trevor and Keith say those are expected, and I believe them. Since this was simply reverting a previous change, I think we can go forward to pushing.
Labels: -Patch-review Patch-push
Originally posted by: k-ohara5...@oco.net
Pushed in commit [r9d3eee5a331f0b242a8aa51256192a4282661f7d]
Labels: -Patch-push fixed_2_15_10
Status: Fixed
Originally posted by: brownian.box@gmail.com
(No comment was entered for this change.)
Status: Verified