Menu
▾
▴
2 Attachments
#1792 dot-notehead collision
Originally created by: *anonymous
Originally created by: k-ohara5...@oco.net
Originally owned by: k-ohara5...@oco.net
%% Dots should move where we can see them,
%% or, if dots need to move and we ask for prefer-dotted-right,
%% then the dotted chord should go on the right.
\relative c {
\clef bass
s1*0^"prefer-dotted-right = #t"
<< <b g' >4 \\ { c8. d16 } >>
<< <b g' >4 \\ { d8. d16 } >>
<< <b g' >4 \\ { f'8. d16 } >>
<< <c a' >4 \\ { g'8. d16 } >>
\override Staff.NoteCollision #'prefer-dotted-right = ##f
s1*0^"prefer-dotted-right = #f"
<< <b g' >4 \\ { c8. d16 } >>
<< <b g' >4 \\ { d8. d16 } >>
<< <b g' >4 \\ { f'8. d16 } >>
<< <c a' >4 \\ { g'8. d16 } >>
}
Patch at <http://codereview.appspot.com/4293054/> changes nothing in the regression tests except the test for this issue.
Discussion
Originally posted by: pkx1... (code.google.com)@gmail.com
Passes make and reg tests although in my case, the reg test 'before' was different - see attached:
Not sure why this was, maybe Keith had something else on his tree? Anyway, the 'after' is the same as Keith's.
Labels: -Patch-new Patch-review
Originally posted by: k-ohara5...@oco.net
> the reg test 'before' was different
As part of the patch, I needed to expand the regression test.
I used the expanded test as the bug report. The before/after output comes from the input shown above in the bug report.
Originally posted by: k-ohara5...@oco.net
Fixed with commit 4dffc56
Labels: -Patch-review fixed_2_15_9
Status: Fixed
Originally posted by: n.putt... (code.google.com)@gmail.com
Did I miss the countdown for this?
Why does the second beat still look bad even with prefer-dotted-right = #t? The lower voice's dot looks as if it's attached to the upper voice; I'd expect this voice to be shifted to the right like the other cases.
TBH, I think the whole concept of prefer-dotted-right as a user property is misguided; there's really no case where we'd want it disabled. Dots should never be moved away from a head unless all voices are dotted.
Originally posted by: k-ohara5...@oco.net
With the fix above for this issue, the behavior matches the documentation.
"prefer-dotted-right (boolean) : For note collisions, prefer to shift dotted up-note to the right, rather than shifting just the dot."
The second beat of the example had no collisions, so the code follows the usual rule keep simultaneous note-heads vertically aligned. This makes sense to me, because voice-crossings are rare, and rhythms tend to repeat, so this way keeps the note-head positioning in its usual pattern whenever possible.
Changing both code and docs to further favor dots on the right, as Neil suggests, could be done (but I don't want to because I like prefer-dotted-right=#f sometimes).
Originally posted by: brownian.box@gmail.com
(No comment was entered for this change.)
Status: Verified