Menu
▾
▴
1 Attachments
#1779 accidentaled notes too far from the barline
Originally created by: *anonymous
Originally created by: k-ohara5...@oco.net
Originally owned by: k-ohara5...@oco.net
Note-columns should be spaced so their main column of note-heads is close to the desired position, with accidentals affecting spacing no more than necessary.
Often, however, Lilypond puts the same space to the left of an accidental as she would to the left of a bare note head.
{ c'4 d' g' d' e'2 a' d'1 <a' d''>2 [r2] }
{ c'4 d' g' d' es'2 a' dis'1 <a' c'' d''>2 [r2] }
<http://lists.gnu.org/archive/html/bug-lilypond/2011-02/msg00262.html>
Patch at http://codereview.appspot.com/4188051/ produces *many* small changes in the regression tests, changes that I suggest we want.
Originally posted by: pkx1...@gmail.com
Passes make and there are lots (lots) of reg test differences but as keith says many 'small' ones, nothing immediately jumps out as bad. But I cannot figure out how to attach them here for others to see.
A pdf > 20MB and making screen shots is not really appropriate (there would be about 60+ pngs)
Labels: -Patch-new Patch-review
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Labels: -Patch-review Patch-needs_work
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Labels: -Patch-needs_work Patch-review
Originally posted by: k-ohara5...@oco.net
The change is:
whenever the first note in a measure has a 'decoration' on the left, place the main note-column as close as possible to where would go if it were bare, but leave 0.3 staff-space clearance between the decoration and the bar line.
(See issue 10, for which it seems 0.3 staff-space clearance will suffice. Also, I checked that issue 242 remains fixed.)
'decorations' can be accidentals, chord fingering, fret diagrams, arpeggios, etc.
Originally posted by: lemniska...@gmail.com
I see two probably problematic regtests; their output is attached.
note-head-chord - while i generally like the idea of suspended noteheads being treated like 'decoration' (i.e. getting less space between it and the barline than a normal, bare notehead would get), i have an impression it's gone a bit too far in this case.
predefined-fretboards-transpose - chord diagrams look definately too crowded now.
Labels: -Patch-review Patch-needs_work
Originally posted by: n.putt...@gmail.com
> Note-columns should be spaced so their main column of note-heads is close to the desired position, with accidentals affecting spacing no more than necessary.
FWIW, Gould disagrees with this. She says accidentals (and other notational elements) should have a staff-space clearance from a mid-line barline unless spacing is cramped, when it's acceptable to move closer (but never less than half a space).
Originally posted by: k-ohara5...@oco.net
That's interesting.
What I usually see in published music is an attempt to keep the note-heads consistently spaced from the bar lines. I'll look at the other textbooks when I'm at the library next week.
Originally posted by: lemniska...@gmail.com
I've randomly picked some scores from imslp.org and both ways of doing this are used (sometimes interchangeably in one score!). I have an impression that what Keith suggests is used more often; at least all engraved examples in our essay are done this way. I find it much more visually pleasing and easier to read (not mentioning that is requires less horizontal space).
Originally posted by: lemniska...@gmail.com
As Keith pointed out, the difference in fretboard diagrams is irrelevant. I also no longer think that note-head-chord should look different than in Keith's patch (i realized that it looks a bit odd mainly because it's quite uncommon).
Labels: -Patch-needs_work Patch-review
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Owner: k-ohara5...@oco.net
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Labels: -Patch-review
Originally posted by: k-ohara5...@oco.net
Fixed with commit 6e39f536
We don't quite have the framework to follow the advice from Gould's book in comment 8,
but at least after this patch increasing the requested space gives non-decreasing in engraved space.
Labels: fixed_2_15_9
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Status: Fixed
Originally posted by: brownian.box@gmail.com
(No comment was entered for this change.)
Status: Verified