Menu
▾
▴
#1773 Add Footnote_engraver to Score context
Originally created by: *anonymous
Originally created by: pkx1...@gmail.com
Originally owned by: dak@gnu.org
This came out of the third draft of a patch I did in
http://codereview.appspot.com/4751045/
For some grobs, the \footnoteGrob command needs the Staff context to be explicitly set. This is a bit awkward frankly and I think, more often than not, when using footnotes staff context are going to be needed for this engraver..
Currently this is only (AFAICT) in the Voice context, I asked generally on the thread above if it could be added into the Staff context *as well* and Neil Puttock said:
--snip--
There are several engravers which exist in multiple contexts (e.g.,
Parenthesis_engraver). I haven't checked, but it seems to me that
adding the Footnote_engraver to the Staff context should be harmless
for Voice-level footnotes.
Cheers,
Neil
--snip--
There is a snippet (or will be - doc additions not yet approved at the time of this tracker) in the NR for the footnote section, showing an explicit staff context being set.
Originally posted by: dak@gnu.org
I've just made some experiments, and some testing with _automatic_ footnotes for normal constructs indicates that adding to lower contexts does not make sense: you'll get a footnote number for _each_ announcement of a grob. So the regtest that "works" at the Staff level does it at the cost of breaking any and all footnotes at the Voice level (of which it prudently contains none).
The "obviously correct" solution is to move Footnote_engraver to Score level. That way, each grob will be announced only once to the footnote engraver.
Since this is actually interfering with the \footnote documentation I am writing, I am preparing a patch that I'll probably shoo in somewhat expeditely.
Summary: Add Footnote_engraver to Score context
Owner: dak@gnu.org
Labels: -Priority-Low
Originally posted by: dak@gnu.org
Issue 1773: move Footnote_engraver to Score context
http://codereview.appspot.com/6254051
Labels: Patch-new
Originally posted by: dak@gnu.org
Issue 1773: move Footnote_engraver to Score context
http://codereview.appspot.com/6254051
Originally posted by: ColinPKC...@gmail.com
Patchy the autobot says: passes tests.
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: dak@gnu.org
Since I need this as the basis for being able to pass the buck again on issue 2547, I am pushing this as [r3f0f59297670174562e7d66ae7dd8d73a04be6f8] to staging.
Labels: -Patch-countdown Fixed_2_15_40
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified