print transposed guitar chords on piano sheets

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#1742 print transposed guitar chords on piano sheets

Status: Accepted

Owner: nobody

Labels: None

Needs:

Patch: abandoned

Type: Enhancement

Updated: 2015-10-25

Created: 2011-07-05

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: lemniska...@gmail.com
Originally owned by: janek.li...@gmail.com

Modify chord-name-engraver to print transposed guitar chords on piano sheets
Add associated properties capoPitch and capoVertical to define-context-properties.

http://codereview.appspot.com/4626094

Discussion

Google Importer - 2011-07-05

Originally posted by: pkx1...@gmail.com

Passes Make and reg tests

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-07-06

Originally posted by: lemniska...@gmail.com

Style nitpicks. And it doesn't work, but the solution has been found probably.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-07-30

Originally posted by: lemniska...@gmail.com

Redesigned patch is here: http://codereview.appspot.com/4800051/

Passes regtests perfectly.

Labels: -Patch-needs_work Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-07-30

Originally posted by: pkx1...@gmail.com

Doesn't pass a make check.

I get an error on

regression/fret-diagrams-string-thickness.ly

log file shows:

Renaming input to: `/home/jlowe/lilypond-git/input/regression/fret-diagrams-string-thickness.ly'
Interpreting music... ERROR: In procedure ly:pitch-transpose:
ERROR: Wrong type argument in position 2 (expecting Pitch): ()

Labels: -Patch-review Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-07-31

Originally posted by: lemniska...@gmail.com

Interesting, nothing was wrong when i tried it previously...
However, new patch from Wol fixes this - make and regtests are compiled nicely.

Labels: -Patch-needs_work Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-02

Originally posted by: lemniska...@gmail.com

I've merged Wol's patches with c++ style formatting changes and ran regtests again from scratch: everything is still fine.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-03

Originally posted by: percival.music.ca@gmail.com

umm... I can't apply the patch directly to git master. It's needs_work.

Labels: -Patch-review Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-03

Originally posted by: lemniska...@gmail.com

It's not issue 4626094 in Rietveld - it's 4800051, sorry.
4800051 applies to git master.
Can we put it on countdown perhaps?

Labels: -Patch-needs_work Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-03

Originally posted by: percival.music.ca@gmail.com

no, because we have 10-ish other patches also waiting. ok, I should have picked 5 patches instead of 4, but I'm on a cheap netbook and I was bored with fighting my crappy 2cm trackpad to click through all the download patch + find out if it still applies or not.

Lesson: keep the list of patch-review in good condition. If you've got a new version of a patch, make sure it's up there. If there's any problems with a patch, move it off the patch-review list.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-05

Originally posted by: lemniska...@gmail.com

(No comment was entered for this change.)

Owner: lemniska...@gmail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-22

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Labels: -Priority-Low
Owner: janek.li...@gmail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-01

Originally posted by: ColinPKC...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-review Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-05

Originally posted by: janek.li...@gmail.com

pushed as [r7770772b6101f60b28173fd68ceb701048016b21]
closed

Labels: -Patch-push fixed2_15_10
Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-05

Originally posted by: n.putt...@gmail.com

Just a comment on this: I did object to the use of a shim to post-process the chord name markup, since there's now a disconnect between the chord name formatter and what actually might get set as the markup text. We don't generally use ly_lily_constant_module to generate markup unless it's actually accessing a markup command.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-05

Originally posted by: tdanielsmusic

(No comment was entered for this change.)

Labels: -fixed2_15_10 fixed_2_15_10

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-05

Originally posted by: lemniska...@gmail.com

Neil:

Sorry! I thought that if issue has label patch-push, there is nothing more to do than push. Should i revert?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-05

Originally posted by: percival.music.ca@gmail.com

Yes, please revert it. Yes, if a patch has the label patch-push, it should be pushed -- but it appears that that one fell through the cracks. Mistakes happen, no big deal.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-06

Originally posted by: janek.li...@gmail.com

reverted.

Labels: -fixed_2_15_10 Patch-needs_work
Status: Started

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-01-24

Originally posted by: ColinPKC...@gmail.com

Last update 20110906

Labels: -Patch-needs_work Patch-abandoned

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trevor Daniels - 2015-10-25

Reverting Status to Accepted as there has been no action in over 4 years.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trevor Daniels - 2015-10-25

Description has changed:

Diff:

status: Started --> Accepted

Needs: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: