Empty contexts sometimes take up too much space

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#1669 Empty contexts sometimes take up too much space

Status: Verified

Owner: nobody

Labels: Fixed_2_17_19 (24)

Needs:

Patch:

Type: Ugly

Updated: 2013-05-27

Created: 2011-05-27

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: k-ohara5...@oco.net
Originally owned by: k-ohara5...@oco.net

% When the first Dynamics line is empty, the second line gets placed at twice
% the minimum distance to the staff.
% This is very rare, because the contexts likely to be empty for a line, but
% not completely removed for that line, do not have a minimum-distance by default
\version "2.13.61"
#(set-default-paper-size "a7")
\paper { indent = 0 }
\score { <<
\new Staff \relative c'' { \clef alto c1 \break c \break c \break }
\new Dynamics { s1\mp s s\mp }
\new Dynamics { s1\sustainOn s\sustainOn s\sustainOn }
%{%} >>
\layout { \context { \Dynamics
\override VerticalAxisGroup #'nonstaff-relatedstaff-spacing
#'stretchability = 0 % alternatively, #'minimum-distance = 4
}}
}

1 Attachments

1669.png

Related

Issues: ~~#3160~~

Discussion

Google Importer - 2011-06-01

Originally posted by: k-ohara5...@oco.net

Thinking about exactly what space empty Dynamics should reserve,
or whether to simply remove Dynamics from rows where they are empty anyway,
using Joe's patch on comment 4 of issue 1442.

Labels: -Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-06-02

Originally posted by: k-ohara5...@oco.net

Patch at http://codereview.appspot.com/4515158/
tidies the rules for spacing an empty line of Dynamics.

The intent is to treat the empty line as if it were there, but zero height, so that any minimum-distance or padding to the main staff is kept (but not doubled).

Labels: Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-06-03

Originally posted by: ColinPKC...@gmail.com

Applied to 2.15.0 with no regressions

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-06-08

Originally posted by: percival.music.ca@gmail.com

some suggestions from Joe.

Labels: -Patch-review Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-06-08

Originally posted by: k-ohara5...@oco.net

Looking for a different approach, that won't complicate the interaction with page-breaking estimates. The tentative patch in comment 4 of issue 1442 might be a reasonable approach.
This is just a low-priority bug discovered while investigating bigger bugs.

Labels: -Patch-needs_work Patch-abandoned

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-06-21

Originally posted by: percival.music.ca@gmail.com

(No comment was entered for this change.)

Status: Accepted

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-20

Originally posted by: percival.music.ca@gmail.com

(No comment was entered for this change.)

Labels: -type-Collision Type-Ugly

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-09

Originally posted by: k-ohara5...@oco.net

The bug is still there, but we need to set minimum-distance explicitly because #'strechability = 0 is no longer a magic special-case.

\version "2.13.61"
#(set-default-paper-size "a7")
\paper { indent = 0 }
\score { <<
\new Staff \relative c'' { \clef alto c1 \break c \break c \break }
\new Dynamics { s1\mp s s\mp }
\new Dynamics { s1\sustainOn s\sustainOn s\sustainOn }
%{%} >>
\layout { \context { \Dynamics
\override VerticalAxisGroup #'nonstaff-relatedstaff-spacing #'minimum-distance = 4
}}
}

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-12

Originally posted by: k-ohara5...@oco.net

Fixed with commit [rd4802c72d26def39030f2ac897b66c3a268888d5] for issue 3160.
I didn't write the patch, but I reported the bug, so I guess I should verify myself.

Status: Verified

1669.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-29

Originally posted by: k-ohara5...@oco.net

The patch linked to issue 3160 fixed this for a while, but caused the problem with page breaking (see comment 6 above and comments on the linked patch) as seen with issue 3338.

Labels: -Priority-Low
Status: Accepted

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-06

Originally posted by: k-ohara5...@oco.net

https://codereview.appspot.com/4515158/

Labels: -Patch-abandoned Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-07

Originally posted by: dak@gnu.org

Patchy the autobot says: Pretty large cell count increases for quite a few files mostly related to page-breaking or span bars. Huge increases in property lookups, about +30%. staff-affinity is tested about 40 times as much as previously. minimum-Y-extent lookups have tripled to reach a rather significant place in the totals. Properties like staff-staff-spacing, important-column-ranks, staff-grouper, pure-Y-common have moved from off the chart to quite significant places. Since I don't see why why this rather heavy performance/memory impact is necessary for the design goals, I'm choosing Needs_work for now.

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-07

Originally posted by: k-ohara5...@oco.net

Thanks for catching that. I had accidentally removed the write to Mike's cache.

http://codereview.appspot.com/4515158/

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-08

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-10

Originally posted by: pkx1...@gmail.com

Patch on countdown for May 13 - 06:00 GMT

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-13

Originally posted by: pkx1...@gmail.com

Patch counted down - please push

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-13

Originally posted by: k-ohara5...@oco.net

commit [r492a7326057fec726684ef429763c745e9ec982b]

Labels: -Patch-push Fixed_2_17_19
Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-17

Originally posted by: k-ohara5...@oco.net

the patch comprised two commits; the other is [r51560f756aa3ab37592c815062e733998accf79c]

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-27

Originally posted by: Elu...@gmail.com

(No comment was entered for this change.)

Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: