Menu
▾
▴
#1501 not_smart rules left in git
Originally created by: *anonymous
Originally created by: percival.music.ca@gmail.com
We're not moving on with stable release plans until I can run convert-ly on the entire git tree and have it automagically work on everything without warnings.
A test:
BUILD_DIR=build scripts/auxiliar/update-with-convert-ly.sh &> foo.txt
reveals a few warnings:
1)
Processing `Documentation/learning/common-notation.itely'...
Applying conversion: 2.13.39, 2.13.40, 2.13.42, 2.13.44, 2.13.46,
Vertical spacing changes might affect user-defined contexts. Please refer to the manual for details, and update manually.2.13.48
2)
Processing `input/regression/lyrics-tenor-clef.ly'...
Applying conversion: 2.12.3, 2.13.0, 2.13.1, 2.13.4, 2.13.10,
Not smart enough to convert minimum-Y-extent; vertical spacing no longer depends on the Y-extent of a VerticalAxisGroup.
Somebody needs to go through these files (and others with the same message), and either:
- update the syntax of any relevant input code, then increase the version number
- increase the version number without changing any code, because of reason X.
Originally posted by: k-ohara5...@oco.net
Manual conversion done in this patch
http://codereview.appspot.com/4001057
Updated a few .ly files that used minimum-Y-extent for staff spacing.
Manually checked that wherever the documentation defines a new context, it is not adversely affected by the new spacing engine (issue 1311).
Originally posted by: percival.music.ca@gmail.com
Fixed, thanks Keith.
Labels: fixed_2_13_49
Status: Fixed
Originally posted by: brownian.box@gmail.com
Looking at raw diff, i'd say it is fixed. Sorry if i am wrong thought.
Status: Verified