Menu
▾
▴
#1442 staff-staff padding all appears after the last nonstaff
Originally created by: *anonymous
Originally created by: RalphBug...@gmail.com
In the new rod-and-spring vertical spacing system, rods sometimes appear in surprising places.
If we have two staves on either side of a non-staff, such as Dynamics or Lyrics, the new system ensures that the requested padding between staves appears as a clearance below the last of the non-staff lines. Also, any staff-staff minimum-distance in excess of that required to avoid collisions, is placed below the lowest intervening non-staff.
The intention, I think, was to let whichever requires the most room -- intervening non-staffs, padding between notes on the staves themselves, or minimum-distance between staves -- determine the staff spacing. Then the non-staff lines should be spaced between the staves according to the options such as UP/DOWN/CENTER that we chose for them.
The override in this example makes the issue more obvious. With no overrides we notice only that the centered dynamics are not quite centered, but a little high because the default staff-staff padding of 1 staff-space is placed below the dynamics.
-Keith
--8<--
\version "2.13.39"
\new PianoStaff \with {
\override StaffGrouper #'staff-staff-spacing #'minimum-distance = #12
} <<
{g' b b g'}
\new Dynamics { s\< s\> s s\!}
{d'' b'' b'' d''} >>
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Originally posted by: PhilEHol...@googlemail.com
(No comment was entered for this change.)
Labels: Priority-High
Originally posted by: k-ohara5...@oco.net
A closely related symptom that could be helpful for debugging, even though it is not the same issue.
If there are several Dynamics lines below a staff, and if the line(s) closest to the staff are empty for a whole system, then the first non-empty Dynamics is placed to allow *twice* the requested minimum-distance from the staff.
\version "2.13.43"
\score { <<
\new Staff { s1*3 }
\new Dynamics { s1\mp \break s1 \break s1\mp }
\new Dynamics { s1\sustainOn s\sustainOn s\sustainOn }
%{%} >>
% Non-essential override to show the extra space varies with
% minimum-distance (and indepenent of padding)
\layout { \context { \Dynamics
\override VerticalAxisGroup #'nonstaff-relatedstaff-spacing #'minimum-distance = #5
}}}
Fortunately, default Dynamics have zero minimum-distance to their parent staff. The analogous situation with Lyrics (which has a minimum-distance by default) does not show the effect.
(The only way I could see the double-distance with Lyrics was to put them between Piano staves and leave in place the "Keep_alive_together_engraver".)
Originally posted by: joenee...@gmail.com
The original issue is fixed. Comment 3 is not a bug: unlike the Lyrics context, the Dynamics context doesn't disappear when it is empty, so it always gets spaced. You can change this behaviour with the attached patch (which I haven't pushed because I don't know if it's desirable, although it does pass the regression tests).
Labels: fixed_2_13_52
Status: Fixed
Originally posted by: k-ohara5...@oco.net
Comment 3 was not intended as a bug report, just behavior that might have been a clue toward solving the issue.
Looks fixed, in git, to me as well.
Originally posted by: PhilEHol...@googlemail.com
(No comment was entered for this change.)
Status: Verified
Originally posted by: joenee...@gmail.com
Unfixed, because the patch caused a regression...
Labels: -fixed_2_13_52
Status: Accepted
Originally posted by: k-ohara5...@oco.net
> Unfixed, because the patch caused a regression...
Specifically, the attempted fix in commit c49d47e385 caused a collision in :
%% Lyrics overlap the lower staff
<<
\new Staff \new Voice = "a" {
b1
}
\new Lyrics \lyricsto "a" {
first
}
\new Lyrics \lyricsto "a" {
second
}
\new Lyrics \lyricsto "a" {
third
}
\new Lyrics \lyricsto "a" {
fourth
}
\new Staff \new Voice {
b1
} >>
% Staff-staff spacing does not notice if we change
%\layout { \context { \Lyrics
% \override VerticalAxisGroup #'nonstaff-nonstaff-spacing
% #'minimum-distance = #9 }}
Originally posted by: joenee...@gmail.com
Let's try this one again...
Labels: fixed_2_13_63
Status: Fixed
Originally posted by: percival.music.ca@gmail.com
Sorry Joe, this will only appear in 2.15.0, not 2.13.63.
Labels: -fixed_2_13_63 fixed_2_15_0
Originally posted by: Carl.D.S...@gmail.com
(No comment was entered for this change.)
Labels: Backport
Originally posted by: Carl.D.S...@gmail.com
Fixed in master with commit [r717f02443c1b93426f4f5d3b18fc8c5045b89a03]
Originally posted by: Carl.D.S...@gmail.com
Backported
Labels: -Backport fixed_2_13_63
Originally posted by: percival.music.ca@gmail.com
(No comment was entered for this change.)
Status: Verified