LilyIssues / Issues / #1266 Dots in chords can not be moved

Google Importer - 2010-09-20

Originally posted by: brownian.box@gmail.com

More examples by Patrick Schmidt:
http://lists.gnu.org/archive/html/bug-lilypond/2010-09/msg00291.html

Regardless of \voice{One,Two,Three,Four} and/or \stem{Up,Down} it seems dots are placed incorrectly and can not be moved by intention.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-26

Originally posted by: brownian.box@gmail.com

(No comment was entered for this change.)

Labels: -Type-Defect -Priority-Medium Type-Ugly

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-01

Originally posted by: justin.o...@gmail.com

It appears that extremal_head_ exists solely to limit the Dots #'direction setting to the main note head. I removed this limitation and it fixed Issue 1266. I've run a few dotting tests and I didn't find any issues with doing this. Still, why was this limitation put in place and can it be removed? Git didn't tell me.

0001-Dots-in-chords-can-not-be-moved-Issue-1266.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-01

Originally posted by: k-ohara5...@oco.net

Git says that "extremal_head_" first appeared in

commit [rf2a58a07b17170c437268cc076c89ba0f33b13a2]
Date:   Tue Jan 6 14:50:35 2004 +0000
    * lily/dot-column.cc (dot_config_badness): new function:
    select the best scoring dot configuration: dots should go close to
    the note heads, but be shifted up or down according to conventions.

The patch looks reasonable. It does move the dot on a lone rest (image from dots.ly regression test). This problem is not so bad considering that Lilypond currently gets stem-down dotted chords wrong. (The tie and overrides in the example above are not required to see the bug.)

Maybe Justin can run the regression suite on his patch and tweak as required, and/or upload it to codereview.appspot.com, or else be patient enough for someone else to help with these things.

dots.preview.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-02

Originally posted by: graham...@gmail.com

Dots in chords can not be moved Issue 1266

http://codereview.appspot.com/5174043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-02

Originally posted by: percival.music.ca@gmail.com

oops, that was my testing account.

Anyway, please review the patch there.

Labels: Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-03

Originally posted by: pkx1...@gmail.com

Passes Make and there are reg tests that show up but I can see no significant changes at first glance.

Attached here

Labels: -Patch-new Patch-review
Owner: janek.li...@gmail.com

Screenshot-1.png

Screenshot-2.png

Screenshot.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-03

Originally posted by: pkx1...@gmail.com

(No comment was entered for this change.)

Status: Started

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-03

Originally posted by: justin.o...@gmail.com

In regards to the rest regression: Previously rests ignored the dots' direction and thus always preferred up. The patch allows rests to respond to direction so a rest in voice two would prefer down. I can make rests ignore direction (as they did pre-patch) or respond to it and have rests prefer down in voice two and four (as in patch).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-03

Originally posted by: k-ohara5...@oco.net

The books (Ross and Stone) talk only about raising/lowering dots after note-heads. I have not yet found a printed example of the situation. ([r4]. is often written [r4] [r8])

The main reason to raise/lower dots on notes, to make clear which voice gets the dot, does not apply to rests because they are placed vertically far enough from the other voice. Also, most rests are unsymmetric top-to-bottom so moving the dot looks strange.

I suggest making rests ignore Dot direction. This avoids a change that might bother some users; there is not currently any way to set options to have dots on rests be placed differently than those on notes.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-03

Originally posted by: justin.o...@gmail.com

New patch. This one applies the Dot direction to all note heads, but not to rests. Should fix regression from first patch as previously discussed.

0001-Dots-in-chords-can-not-be-moved-Issue-1266.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-03

Originally posted by: pkx1...@gmail.com

I applied the patch (thanks Justin) and it passes make, I still get one regression test show up.

See attached.

I haven't loaded this on Rietveld yet only because I know that Graham did the first time and I won't be able to on the same issue.

Screenshot.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-03

Originally posted by: k-ohara5...@oco.net

Great! The remaining regression test change shows the bug being fixed.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-04

Originally posted by: percival.music.ca@gmail.com

new version uploaded:

http://codereview.appspot.com/5174043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-06

Originally posted by: ColinPKC...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-09

Originally posted by: ColinPKC...@gmail.com

Counted down to 20111009

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-29

Originally posted by: pkx1...@gmail.com

Graham, this rietveld is owned by you even though the tracker is Janek (who is away) can you (did you?) push this?

James

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-29

Originally posted by: percival.music.ca@gmail.com

huh, I'd completely lost track of it. Yes, if Justin sends me his patch, I'll push it. Or you could push it for him.

oh wait, it's already here. James, could you push it to dev/staging ?

Owner: ---

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-30

Originally posted by: pkx1...@gmail.com

Hello, Yes I can do that - I need to get into the habit of the new workflow.

Can I just check the command I need to use is:

git push origin dev\staging

and that is it - I don't want to break anything with my push access.

Eg. I don't need to download a new repo just for dev/staging do I, I can just push from my own lilypond-git repo to dev/staging?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-30

Originally posted by: pkx1...@gmail.com

Thanks to David's advice this is now pushed (I hope) to dev/staging

--snip--

jlowe@jlowe-lilybuntu2:~/lilypond-git/build$ git push origin
HEAD:refs/heads/dev/staging
Counting objects: 13, done.
Delta compression using up to 7 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 651 bytes, done.
Total 7 (delta 6), reused 0 (delta 0)
To ssh://pkx166h@git.sv.gnu.org/srv/git/lilypond.git
2f1556b..b5f1985 HEAD -> dev/staging

--snip--

I'm not clear if I can mark this as Patch-fixed because of (or in spite of) the fact it is in dev/staging and not master.

So will leave that alone for now.

James

Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-11-06

Originally posted by: PhilEHol...@googlemail.com

It's not fixed in 2.15.16

Labels: Fixed_2_15_17

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-11-13

Originally posted by: PhilEHol...@googlemail.com

(No comment was entered for this change.)

Labels: -Patch-push
Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dots in chords can not be moved

Issue Tracker for LilyPond

Searches

Help

#1266 Dots in chords can not be moved

Discussion