Menu

#1255 Extract hyphen dimensions and/or hyphen glyph from the font

Started
None
needs_work
Enhancement
2017-10-04
2010-09-09
Anonymous
No

Originally created by: *anonymous

Originally created by: RalphBug...@gmail.com

LyricHyphen does not use the glyph of the LyricText font, but instead a custom line markup. Alexander Kobel: "Once I also tried to exchange the LyricHyphen stencil to mimic LyricText, but to no avail - AFAICS, the alignment of the hyphens is more or less hard-coded in the C++ part."

lily/lyric-hyphen.cc: (line 555-556)
"TODO: should extract hyphen dimensions or hyphen glyph from the font."

--

Allow a markup to replace the default LyricHyphen

Solves issue #1255.

Signed-off-by: Knut Petersen knut_petersen@t-online.de

http://codereview.appspot.com/325470043

Discussion

  • Google Importer

    Google Importer - 2010-10-02

    Originally posted by: percival.music.ca@gmail.com

    (No comment was entered for this change.)

    Labels: -Type-Other Type-Enhancement Priority-Low

     
  • Simon Albrecht

    Simon Albrecht - 2016-09-27
    • summary: Add prefix to lyrics - extract hyphen dimensions or hyphen glyph from the font --> Extract hyphen dimensions and/or hyphen glyph from the font
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: -->
     
  • Simon Albrecht

    Simon Albrecht - 2016-09-27

    The current behaviour also has its pros. I think we should allow for both by providing different stencil procedures, like ly:lyric-hyphen::print-flexible and ly:lyric-hyphen::print-from-font (names to be discussed). In the latter case, text-interface properties would be read.

     
  • Knut Petersen

    Knut Petersen - 2017-09-14

    Allow a markup to replace the default LyricHyphen

    Solves issue #1255.

    Signed-off-by: Knut Petersen knut_petersen@t-online.de

    http://codereview.appspot.com/325470043

     
  • Anonymous

    Anonymous - 2017-09-14
    • assigned_to: pkx166h
    • Needs: -->
    • Type: -->
     
  • Knut Petersen

    Knut Petersen - 2017-09-14

    Version 2 of issue #1255 patch

    http://codereview.appspot.com/325470043

     
  • Knut Petersen

    Knut Petersen - 2017-09-14

    Test file changed to support the V2 syntax.

     
  • Anonymous

    Anonymous - 2017-09-14
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -6,3 +6,13 @@
    
     lily/lyric-hyphen.cc: \(line 555-556\)
      "TODO: should extract hyphen dimensions or hyphen glyph from the font."
    + 
    + --
    + 
    + Allow a markup to replace the default LyricHyphen
    +
    +Solves issue #1255.
    +
    +Signed-off-by: Knut Petersen knut_petersen@t-online.de
    +
    +http://codereview.appspot.com/325470043
    
    • Needs: -->
    • Type: -->
     
  • Anonymous

    Anonymous - 2017-09-14
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-09-14

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-09-16
    • Patch: review --> countdown
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2017-09-16

    Patch on countdown for September 19th

     
  • Knut Petersen

    Knut Petersen - 2017-09-19

    It is more important to work on the ghostscript issue right now.

     
  • Anonymous

    Anonymous - 2017-09-20

    I cannot see that getting resolved any time 'soon' so do you want to push this or not?

     
  • Anonymous

    Anonymous - 2017-09-23
    • assigned_to: pkx166h --> Knut Petersen
     
  • Anonymous

    Anonymous - 2017-09-23

    Setting back to needs work.

     
  • Anonymous

    Anonymous - 2017-09-23
    • Patch: countdown --> needs_work
     
  • Knut Petersen

    Knut Petersen - 2017-10-04

    Issue 5210 has been opened. The proposed patch does not entirely solve this issue, so it is better to keep this open and use a new issue.

     
MongoDB Logo MongoDB