Menu
▾
▴
#1236 CG+scripts should use $LILYPOND_GIT
Originally created by: *anonymous
Originally created by: percival.music.ca@gmail.com
Originally owned by: m...@hohlart.de
lily-git.tcl creates a repository in ~/lilypond-git/
All scripts should be adjusted to either:
- use this as the default location of lilypond
- figure out the directory automatically
the second option is more complicated, so I recommend the first one.
All parts of the CG should be similarly rewritten; IIRC there's at least three different "standard" or "suggested" locations for lilypond.
EXCEPTION:
- the website build stuff should remain as ~/lilypond/lilypond-git/ because of shared user stuff.
FROG: 5 hours.
Originally posted by: percival.music.ca@gmail.com
(No comment was entered for this change.)
Labels: -Maintainability Type-Maintainability
Originally posted by: percival.music.ca@gmail.com
We should standardize on $LILYPOND_GIT instead of a hard-coded directory.
1) lilydev needs to be updated
2) all scripts which use an absolute or home-based directory should be updated
3) CG needs to be updated
FROG: not counting #1, I'm bumping this up to 10 hours.
Summary: CG+scripts should use $LILYPOND_GIT
Labels: -Priority-Medium
Originally posted by: adam.spi...@gmail.com
For a shell script such as doc-section.sh, auto-detection is as simple as:
cd "`dirname $0`"
cd ../..
LILYPOND_GIT="`pwd`"
Obviously auto-detection is preferably from a usability standpoint, but if other non-shell executables or processes cannot do auto-detection then I agree an environment variable would be far preferable to hard-coding it. But where auto-detection *can* occur, is there any reason not to prefer it to using the environment variable? The only reasons I can imagine they would yield different answers is (a) due to symlinked directories, or (b) the environment variable was set wrong. In the (a) case it wouldn't matter because the two paths would still point to the same place even if they looked different.
Originally posted by: adam.spi...@gmail.com
Pushed [rf955789f0e1726c03b554a9fde21494687ae95b8] to staging which addresses several of the issues here, if not all.
Status: Started
Originally posted by: m...@hohlart.de
Issue 1236: CG+scripts should use $LILYPOND_GIT
http://codereview.appspot.com/6483057
Labels: Patch-new
Originally posted by: m...@hohlart.de
Issue 1236: CG+scripts should use $LILYPOND_GIT
http://codereview.appspot.com/6483057
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes tests.
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Owner: m...@hohlart.de
Originally posted by: ColinPKC...@gmail.com
Counted down to 20120828, please push.
Labels: -Patch-countdown Patch-push
Originally posted by: m...@hohlart.de
(No comment was entered for this change.)
Labels: -Patch-push Fixed_2.17.1
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Labels: -Fixed_2.17.1 Fixed_2_17_2
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified