LilyIssues / Issues / #1204 Documentation and regtests needed for external font files

David Kastrup - 2020-04-09

dak@lola:/usr/local/tmp/lilypond$ out/bin/lilypond input/regression/font-name-add-files.ly
GNU LilyPond 2.21.0
Processing input/regression/font-name-add-files.ly' Parsing... Finding the ideal number of pages... Fitting music on 1 page... Drawing systems... Layout output to/tmp/lilypond-QdY0Wz'...
Converting to font-name-add-files.pdf'... Deleting/tmp/lilypond-QdY0Wz'...
input/regression/font-name-add-files.ly:244:4: error: GUILE signaled an error for the expression beginning here
#
(rmdir dummyfontdir)
Directory not empty
Finding the ideal number of pages...
Fitting music on 1 page...
Drawing systems...
Layout output to /tmp/lilypond-G1lETy'... Converting tofont-name-add-files-1.pdf'...
Deleting `/tmp/lilypond-G1lETy'...
fatal error: failed files: "input/regression/font-name-add-files.ly"

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Valentin Villenave - 2020-04-10
  
  On 4/9/20, David Kastrup dakas@users.sourceforge.net wrote:
  
  dak@lola:/usr/local/tmp/lilypond$ out/bin/lilypond
  #(rmdir dummyfontdir)
  Directory not empty
  
  I’m at a loss:
  
  valentin  /  lilypond 
  $: out/bin/lilypond input/regression/font-name-add-files.ly
  GNU LilyPond 2.21.0
  Processing input/regression/font-name-add-files.ly' Parsing... Finding the ideal number of pages... Fitting music on 1 page... Drawing systems... Layout output to/tmp/lilypond-5kKSn3'...
  Converting to font-name-add-files.pdf'... Deleting/tmp/lilypond-5kKSn3'...
  Finding the ideal number of pages...
  Fitting music on 1 page...
  Drawing systems...
  Layout output to /tmp/lilypond-BWlrq2'... Converting tofont-name-add-files-1.pdf'...
  Deleting `/tmp/lilypond-BWlrq2'...
  Success: compilation successfully completed
  
  Cheers,
  V.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Valentin Villenave - 2020-04-09

Patch: needs_work --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-11

Valentin, it might be my fault - looking through this thread there are at least 2 different rietvelds. Phil's 'script' that scrapes Allura and that I use to pick up the URL for the patchy email (and saves me a lot of time hunting long threads) may have picked up the wrong one which I had tested.

But the commit that david links above is NOT the same (I think) as what I tested.

So, can you clarify which Rietvled we're looking at?

Thanks,

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Valentin Villenave - 2020-04-11
  
  This is https://codereview.appspot.com/557640051/, patch set #4. I did make a mistake when I posted my "pushed as" URL.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-13

I'll retest the patch again.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-13

Passes make, make check and a full make doc.

Reg test diff attached

Reg_test_patch_4.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-15

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-15

Patch on countdown for April 17th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-17

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-17

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Valentin Villenave - 2020-04-20

Issue #1204: fix font-name-add-files regtest

The temporary directory might not be empty if some
versions of fontconfig add a .uuid file inside it.

https://codereview.appspot.com/573730044

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-20

Passes make, make check and a full make doc.

Screenshot from 2020-04-20 20-31-37.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-20

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jonas Hahnfeld - 2020-04-20

Description has changed:

Diff:

--- old +++ new @@ -1,4 +1,5 @@ https://codereview.appspot.com/557640051 +new: https://codereview.appspot.com/573730044 *Originally created by:* *anonymous
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jonas Hahnfeld - 2020-04-20

Oh, now there is a second review and http://www.philholmes.net/lilypond/allura/ picks up the wrong one :-( James, I assume you tested the old patch?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Valentin Villenave - 2020-04-20

More concise (or ...) syntax for conditional switch

https://codereview.appspot.com/573730044

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-20

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-20

Passes make, make check and a full make doc.

@jonas - I tested the right patch - having made that mistake already last week.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-21

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-21

Patch on countdown for April 23rd

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-23

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-23

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Valentin Villenave - 2020-04-23

labels: --> Fixed_2_21_1

status: Started --> Fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- David Kastrup - 2020-04-23
  
  "Valentin Villenave" v_villenave@users.sourceforge.net writes:
  
  labels: --> Fixed_2_21_1
  
  status: Started --> Fixed
  
  Comment:
  
  n-th time’s the charm: pushed as
  https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=8b1785909543f6ecb97a962067e75bb97e2caec1
  
  Seriously? You pushed the old test again. Removing from staging.
  
  Feel free to try again. At least this time I caught it before it got
  into master by someone else's Patchy.
  
  --
  David Kastrup
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Documentation and regtests needed for external font files

Issue Tracker for LilyPond

Searches

Help

#1204 Documentation and regtests needed for external font files

Discussion