Menu
▾
▴
#1184 easier rietveld patches
Accepted
nobody
None
policy
Maintainability
2011-08-25
2010-07-14
Anonymous
No
Originally created by: *anonymous
Originally created by: percival.music.ca@gmail.com
1. is there any maoing way to view all rietveld patches for lilypond? IIRC there's such a thing for user-specific patches, so hopefully there is. Also, rietveld is an appspot thing; maybe if we had a "lilypond" google apps thing, we could have a dedicated code review?
(I'm not actually proposing the latter, but I'd like somebody to look into the possibility)
2. how should non-developers comment on patches? Do we encourage/force everybody to use rietveld, or let non-devels use email, or what?
I'll probably tackle these if nobody else does in the next two or three weeks.
Originally posted by: pnorcks@gmail.com
I think it would be best if we eventually migrate *away* from Rietveld, primarily because it is based on SVN, and that isn't going to change.
Here's an idea:
We set up a page on lilynet, maybe http://codereview.lilynet.net, that uses Gerrit (https://code.google.com/p/gerrit/).
Gerrit is extremely easy to set up, and the only dependency is a Java Runtime Environment. Everything else is bundled in the web application (gerrit-*.war).
Regarding your second point, Gerrit uses OpenID logins by default, but Google accounts are also supported.
Originally posted by: v.villenave
That's a nice idea; obviously we should discuss it with more LilyPond developers before making any move.
John is currently setting up a git repo on a lilynet subdomain, which we could probably use to test Gerrit. (There's also http://www.reviewboard.org/ that seems appealing.)
Graham: I've been using Google apps domain quite a bit, but I don't think Rietveld is fully integrated with it yet (particularly, as Patrick pointed out, when it comes to non-svn projects). The inability for Rietveld to simply display every patches related to a specific project puzzles me as well: it makes a Patch-Meister's job a *lot* more difficult.
Originally posted by: percival.music.ca@gmail.com
(No comment was entered for this change.)
Labels: -Maintainability Type-Maintainability
Originally posted by: percival.music.ca@gmail.com
(No comment was entered for this change.)
Labels: -Priority-Medium Needs-policy