#1128 Text pedal mark not closed at music end

[Anonymous]

Originally created by: *anonymous

Originally created by: PhilEHol...@googlemail.com

Notation reference 2.2.2 says "Pedalling to the final bar line is indicated by omitting the final pedal up command.".  This behaviour works for bracket-style pedal markings, but not text-style.  As a result, it's impossible to indicate a pedal up mark at the end of a piece of music, except by adjusting horizontal spacing.

The example below shows the bracket closing as expected, but the pedal up text marking not being placed.  The best that can be done is shown in the 3rd and 4th examples, and the desired behaviour shown in the attached image, with the pedal up being moved courtesy of photoshop.

TestPedalMusic = \relative c {
  \clef "bass"
  c2_\sustainOn  c2 \bar "|."
}

TestPedalMusicAlt = \relative c {
  \clef "bass"
  c2_\sustainOn  c2_\sustainOff \bar "|."
}

\new Staff { \TestPedalMusic }
\new Staff { \set Staff.pedalSustainStyle = #'bracket \TestPedalMusic }
\new Staff { \TestPedalMusicAlt }
\new Staff { \set Staff.pedalSustainStyle = #'bracket \TestPedalMusicAlt }

[Google Importer]

Originally posted by: jesse....@gmail.com

As a temporary non-Photoshopped alternative,

  \override Staff.PianoPedalBracket #'shorten-pair = #'(0 . -6.0)

with adjustments to the negative value allows the pedal marking to be extended to the desired location. A more permanent fix would be to implement an override which extends the pedal spanner to the bar line.

[Google Importer]

Originally posted by: brownian.box@gmail.com

Kieren MacMillan offered C$25 bounty on a fix.
http://lists.gnu.org/archive/html/lilypond-user/2011-06/msg00630.html

Labels: Bounty

[Google Importer]

Originally posted by: reinhold...@gmail.com

The problem is that the brackets use a spanner, which will properly end, while the text style uses separate grobs for each of the texts ("Ped.", "*Ped." and "*"). Now, if a \sustainOn does not have a closing \sustainOff, we can handle that case in the Engraver's finalize () method. Unfortunately, it seems that at that time it is too late to create a new grob for the final "*", but we don't know before whether we need a final "*"....

I've tried to implement the creation of the "*" in ::finalize, but the following patch always crashes (valgrind shows access to some unallocated memory in the page breaking code):
http://codereview.appspot.com/5015045

So, apparently creating a grob for "*" in ::finalize does not work. Any idea how to make this work?

[Google Importer]

Originally posted by: pkx1...@gmail.com

Just adding patch-needs_work to tracker so that it shows up as at least having a patch.

Labels: Patch-needs_work

[Google Importer]

Originally posted by: n.putt...@gmail.com

> So, apparently creating a grob for "*" in ::finalize does not work. Any idea how to make this work?

Couldn't you create the grob earlier so it's available if necessary, then suicide it if it's unused?

[Google Importer]

Originally posted by: ColinPKC...@gmail.com

Last update 20110914

Labels: -Patch-needs_work Patch-abandoned

[Google Importer]

Originally posted by: PhilEHol...@googlemail.com

Bounty of 50 GBP for this one.  Pedal closing marks are generally not placed well - the code:

c''1_\sustainOn
c''1_\sustainOff

gives the attached image - the * is far too far to the right - it should be on the bar line.

[Google Importer]

Originally posted by: lemzw...@googlemail.com

Regarding comment #7: It depends.  Attached you can find a scan of a Beethoven piano sonata (http://imslp.org/wiki/File:Beethoven,L.v.-_Piano_Sonata_23.pdf) where the * sign is positioned exactly under the note – probably following the autograph as close as possible.  So similar to crescendo hairpins, there should be an option to control whether the * ends shortly before the barline or exactly below the note.  If both \sustainOn and \sustainOff are attached to the same note, and both symbols should be positioned below the note, the * should be moved to the left.