Menu

#4976 Add annotation of \shape-d curves (WIP)

Started
None
needs_work
Enhancement
2016-09-25
2016-09-22
Urs Liska
No

Add annotation of \shape-d curves (WIP)

This code is not ready for inclusion because I need some help.
Basically I'm happy with what it does, but I don't know how to
make it support broken slurs as well.
Additionally I don't understand how \shape works as a post-event,
and it doesn't work yet.

(I'll update the documentation once the patch is ready for
inclusion.)

Actually I would like to define some of the functions not as
local functions but as globally available routines because the
\compoundSlur code will be able to use it, and it will make it
easier to later incorporate \compoundSlur as well.

  • Add optional first boolean argument to turn on annotation
  • print control points with connection to end points
  • print (lightly) original slur with control points

Limitations:
- doesn't work with broken spanners yet
- doesn't work when item is not present

http://codereview.appspot.com/303650043

1 Attachments

Discussion

  • Urs Liska

    Urs Liska - 2016-09-22
    • Description has changed:

    Diff:

    
    
    • Attachments has changed:

    Diff:

    --- old
    +++ new
    @@ -0,0 +1 @@
    +annotate-shape.png (15.2 kB; image/png)
    
    • Needs: -->
     
  • Urs Liska

    Urs Liska - 2016-09-22

    Re-commit without the reformatting

    http://codereview.appspot.com/303650043

     
  • Simon Albrecht

    Simon Albrecht - 2016-09-22

    IIUC using it as a post-event would work if it were an event-function, but I think that would break the \shape #'foo Slur c128( version… so I can’t explain either how it works now.

     
  • Anonymous

    Anonymous - 2016-09-25

    Fails make check/doc

    From log files this snippet turns up.

    <<
      {
        e'1-\shape #'((0 . 0.5) (0 . 1) (0 . 1) (0 . 0.5)) ~ e'
      }
    \\
      \relative { r4 <g' c,> <g c,> <g c,> }
    >>
    

    This is found here:

    http://lilypond.org/doc/v2.19/Documentation/notation-big-page.html#modifying-ties-and-slurs

    Third example (I think).

     
  • Anonymous

    Anonymous - 2016-09-25
    • Needs: -->
    • Patch: new --> needs_work
    • Type: --> Enhancement
     

Log in to post a comment.