Menu
▾
▴
#4936 MIDI: Look up "mf" instead of hard-coding a numeric default volume
This tracker was created out of a comment from Review of https://codereview.appspot.com/302930043#msg10
(itself from https://sourceforge.net/p/testlilyissues/issues/4920/)
implementation should simply be changed to query for the default value
from the default absolute volume map using one of the keys defined in
scm/midi.scm (and I agree that "mf" is probably a reasonable choice).
If this plan is accepted, you could conscientiously document “mf” as the default now.
I volunteer to make the change. If someone would create a ticket and assign it to me, it would help me remember.
—
Dan
Issue 4936: look up "mf" for default initial volume
When the Dynamic_performer begins processing, if no dynamic is
specified, act as if "mf" were specified.
Changes in note velocity from 90 to 86 in many MIDI regression tests
are expected.
http://codereview.appspot.com/308890043
Passes make, make check and a full make doc.
Patch on countdown for August 6th
This looks like (to me) this still needs some discussion, so I'll put this back to review for now.
Patch on countdown for August 12th.
This is going back on review again based on the ongoing discussion on Rietveld
Patch on countdown for August 18th
Motivation has been lacking lately. I expect to return to this after some time (a week? a month?) but if someone else would like to take over this issue before then, I won't be offended.