#4563 PATCH: Change PDF 'author' field to use /Author not /Composer

[Anonymous]

Originally created by: *anonymous

Originally created by: pkx1... (code.google.com)@gmail.com
Originally owned by: pkx1... (code.google.com)@gmail.com

Currently, the PDF author field is filled with the composer. This is nice fall back but in most cases the author of the document and the composer will be different. While I can write pdfcomposer = "Author Name" it appears as intended as /Author(Author Name) but it also appears as /Composer(Author Name) which is wrong. Wouldn't it make sense to offer both fields: Author and Composer separately? A fallback if no author is given makes sense but it would be good to be able to specify an author differing from the composer.

https://codereview.appspot.com/260200043

[Google Importer]

Originally posted by: pkx1... (code.google.com)@gmail.com

This passes make, make check and a full make doc. However reg tests show programming errors

for example

--snip--

Writing ./voice-4-midi-systems.tex...
Writing ./voice-4-midi-systems.count...
Writing timing to voice-4-midi.profile...
+programming error: Parsed object should be dead: #<Context_def CueVoice /home/james/lilypond-git/build/out/share/lilypond/current/ly/performer-init.ly:110:1>
+continuing, cross fingers
+programming error: Parsed object should be dead: #<Prob: Music C++: Music((origin . #<location out-test/voice-4-midi.ly:72:3>))((display-methods #<procedure #f (check)>) (name . BarCheck) (types bar-check) (iterator-ctor . #<primitive-procedure ly:bar-check-iterator::constructor>)) >
+
+continuing, cross fingers

input/regression/midi/voice-4-midi.log

--snip--

MOst (if not all of the Midi reg tests show this same error)

Labels: -Patch-new Patch-needs_work

[Phil Holmes]

I've created a new patch for this at:

https://codereview.appspot.com/264970043/

This uses author and pdfauthor as the normal fields to set Author in the PDF properties.

[Trevor Daniels]

Sorry Phil - I misunderstood and duplicated this entry.

I'll delete my comment.

Trevor

----- Original Message -----
From: "Phil Holmes" philholmes@users.sf.net
To: "[testlily:issues-2015-08-17] " 4563@issues-2015-08-17.testlily.p.re.sf.net
Sent: Sunday, August 30, 2015 4:34 PM
Subject: [testlily:issues-2015-08-17] Ticket 4563 discussion

I've created a new patch for this at:

https://codereview.appspot.com/264970043/

This uses author and pdfauthor as the normal fields to set Author in the PDF properties.

---

** [issues-2015-08-17:#4563] PATCH: Change PDF 'author' field to use /Author not /Composer**

Status: Started
Created: Sat Aug 15, 2015 02:46 PM UTC by Anonymous
Last Updated: Sat Aug 15, 2015 03:22 PM UTC
Owner: nobody

Originally created by: *anonymous

Originally created by: pkx1... (code.google.com)@gmail.com
Originally owned by: pkx1... (code.google.com)@gmail.com

Currently, the PDF author field is filled with the composer. This is nice fall back but in most cases the author of the document and the composer will be different. While I can write pdfcomposer = "Author Name" it appears as intended as /Author(Author Name) but it also appears as /Composer(Author Name) which is wrong. Wouldn't it make sense to offer both fields: Author and Composer separately? A fallback if no author is given makes sense but it would be good to be able to specify an author differing from the composer.

https://codereview.appspot.com/260200043

---

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/testlily/issues-2015-08-17/4563/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

[Phil Holmes]

Belay that. Think this is the old test trackers.