TestLily / Issues / #155 \parenthesize does not take accidentals into account

Google Importer - 2008-05-30

Originally posted by: v.villenave

(Reproduced with 2.11.47)

Summary: \parenthesize should take accidentals into account

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2008-10-10

Originally posted by: v.villenave

Risto suggests that the parentheses should include the accidental, as shown is the
attached picture.

See also http://lists.gnu.org/archive/html/lilypond-user/2008-10/msg00391.html

Summary: \parenthesize should include accidentals as well as note heads
Owner: v.villenave
Labels: -Type-Defect -Priority-Low Type-Enhancement Priority-Medium

parenthesizing_note_head_and_accidental_rgb.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2009-10-08

Originally posted by: perpeduu...@gmail.com

The same should hold for dotted notes.

\version "2.13.5"
\relative c'' { <\parenthesize cis>2. }

paren.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2009-10-09

Originally posted by: v.villenave

Definitely! Added as Issue 868.

Summary: \parenthesize does not take accidentals into account
Labels: -Type-Enhancement Type-Collision

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-05-21

Originally posted by: mts...@gmail.com

This can now be worked around in the most recent git. Same holds true for Issue 868.

\score {
\new Staff { <\parenthesize ais'> }
\layout {
    \context {
      \Voice
      \override ParenthesesItem #'stencil = #(lambda (grob)
       (let* ((acc (ly:grob-object (ly:grob-parent grob Y) 'accidental-grob))
              (dot (ly:grob-object (ly:grob-parent grob Y) 'dot)))
         (if (not (null? acc)) (ly:pointer-group-interface::add-grob grob 'elements acc))
         (if (not (null? dot)) (ly:pointer-group-interface::add-grob grob 'elements dot))
         (parentheses-item::print grob)))
}}}

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-05-22

Originally posted by: ahawry...@gmail.com

Bravo! This is very exciting. Just a heads up though, this example seems to prefer parentheses that align with spaces rather than lines:

\version "2.15.0"
\score {
\new Staff {
    % parentheses not included in spacing calculations
    \override Voice.NoteColumn #'X-extent = #'(-10 . 10)
    <\parenthesize ais'>4. <\parenthesize bes'>
}
\layout {
    \context {
      \Voice
      \override ParenthesesItem #'stencil = #(lambda (grob)
       (let* ((acc (ly:grob-object (ly:grob-parent grob Y) 'accidental-grob))
              (dot (ly:grob-object (ly:grob-parent grob Y) 'dot)))
         (if (not (null? acc)) (ly:pointer-group-interface::add-grob grob 'elements acc))
         (if (not (null? dot)) (ly:pointer-group-interface::add-grob grob 'elements dot))
         (parentheses-item::print grob)))
    }
}
}

parens.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-07-20

Originally posted by: reinhold...@gmail.com

Issue 868 has been merged into this issue.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-07-24

Originally posted by: lemniska...@gmail.com

Interesting. I thought that maybe the parentheses ended up in space because it was aligned to dot instead of notehead, but this is not the case. I. e. adding \voiceTwo to the music doesn't change parentheses' position.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-07-24

Originally posted by: reinhold...@gmail.com

The parentheses are always vertically aligned with the center of the stencil. The long vertical line of the b moves it up quite a bit.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-20

Originally posted by: percival.music.ca @gmail.com

(No comment was entered for this change.)

Labels: -type-Collision Type-Ugly

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-16

Originally posted by: joenee...@gmail.com

Here's a patch: http://codereview.appspot.com/5032047
It vertically centers the parentheses around the note-head.

Status: Started

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-17

Originally posted by: pkx1...@gmail.com

(No comment was entered for this change.)

Labels: Patch-new
Owner: joenee...@gmail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-17

Originally posted by: pkx1...@gmail.com

Passes make and reg tests

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-17

Originally posted by: joenee...@gmail.com

Here's a patch with a better description:
http://codereview.appspot.com/5047048

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-20

Originally posted by: percival.music.ca @gmail.com

(No comment was entered for this change.)

Labels: -Priority-Medium -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-21

Originally posted by: ColinPKC...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-26

Originally posted by: joenee...@gmail.com

Fix 155: parentheses include accidentals and dots.

Make parentheses around noteheads include accidentals and dots.
Make parentheses around rests include dots.

http://codereview.appspot.com/5047048

Labels: Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-26

Originally posted by: percival.music.ca@gmail.com

(No comment was entered for this change.)

Labels: -Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-27

Originally posted by: pkx1...@gmail.com

Passes make but I get some reg test 'crossing fingers' messages

--snip--

/home/jlowe/lilypond-git/input/regression/tablature-grace-notes.log

@@ -2,6 +2,10 @@
Renaming input to: `/home/jlowe/lilypond-git/input/regression/tablature-grace-notes.ly'
Interpreting music...
Preprocessing graphical objects...
+programming error: no pure Y common refpoint
+continuing, cross fingers
+programming error: no pure Y common refpoint
+continuing, cross fingers
Calculating line breaks...
Drawing systems...
Writing header field `texidoc' to `/home/jlowe/lilypond-git/build/out/lybook-testdb/3b/lily-8f72236e.texidoc
--snip--

See attached

Labels: -Patch-new Patch-needs_work

Screenshot-1.png

Screenshot-2.png

Screenshot.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-11-03

Originally posted by: ColinPKC...@gmail.com

Is this still being worked on? The last update was over a month ago.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-01-24

Originally posted by: ColinPKC...@gmail.com

Last update 20110927

Labels: -Patch-needs_work Patch-abandoned

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-12-23

Originally posted by: pkx1...@gmail.com

Also see
https://code.google.com/p/lilypond/issues/detail?id=3750

Owner: ---

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-04-08

Originally posted by: simon.al...@mail.de

The current workaround is in http://lsr.di.unimi.it/LSR/Item?id=972.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-04-14

Originally posted by: Carl.D.S...@gmail.com

Updated patch for issue 155

This patch is updated from Joe Neeman's patch for issue 155 so it applies to current master.

The main difference is the change in handling pure functions. I'm not an expert on this so I'm not sure I have it 100% right.

But at least this works on the regtests.

Please review.

http://codereview.appspot.com/230860044

Labels: -Patch-abandoned Patch-new
Owner: Carl.D.S...@gmail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-04-15

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes tests. Includes a full make doc

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

\parenthesize does not take accidentals into account

Test issue tracker

Searches

Help

#155 \parenthesize does not take accidentals into account

Related

Discussion